bib: extract common platformFor() helper and add tests
#693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit populates the "img.Platform" struct when building ISOs for s390x and ppc64le. No tests right now sadly, this should be looked into but given that it is known broken right now this change can hardly make it worse. Closes: osbuild#686
This commit extracts a common `platformFor` helper to generate a platform for the (arch, imageForamat, UEFIVendor) tuple. Note that this also change is not a pure refactor but change the following behavior: - `QCOW2Compat: "1.1"` is no longer set because this is the default in qemu since 2013 (upstream commit 8ad1898c version qemu 1.7) - uefi vendor is now set for the disk image according to source info. This used to be hardcoded for aarch64 and unset for the others. This should be mostly irrelevant as only installers and the bootc legacy pipeline that uses ostree stages directly need it. But having it should do not harm and until PR#689 is merged we will need for the bootc legacy pipeline. But if this looks too risky I can revert, adding architectures happens rarely enough and maybe this refactor is overkill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[build on top of https://github.com//pull/692]
This commit extracts a common
platformForhelper to generatea platform for the (arch, imageForamat, UEFIVendor) tuple.
Note that this also change is not a pure refactor but change
the following behavior:
QCOW2Compat: "1.1"is no longer set because this is thedefault in qemu since 2013 (upstream commit 8ad1898c
version qemu 1.7)
info. This used to be hardcoded for aarch64 and unset for the
others. This should be mostly irrelevant as only installers
and the bootc legacy pipeline that uses ostree stages directly
need it. But having it should do not harm and until PR#689
is merged we will need for the bootc legacy pipeline.
But if this looks too risky I can just close the PR, adding architectures
happens rarely enough and maybe this refactor is overkill.