test: add integration test for reporting errors from osbuild #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a proper integration test that ensures that we always report the details of a failing osbuild run. This prevents regressions like the one from osbuild#810. This ensures that: a) we report the messags from a broken stage b) we report any osbuild messages as well to catch e.g. crashes that are not reported via the json progress It is archived by creating a new build container fixture that is deliberately broken, i.e: a) the org.osbuild.selinux stage is replaced with a fake that will echo some msgs and then error b) osbuild itself is is wrapped around so that we can reliably echo some canary strings before the real osbuild is executed
mvo5
force-pushed
the
tweak-tweak-progress-errors-integration-test
branch
from
8366e01 to
d0522cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[build on top of https://github.com//pull/820 in an extra PR to ensure we can land #820 asap]
This commit adds a proper integration test that ensures that we
always report the details of a failing osbuild run. This prevents
regressions like the one from #810.
This ensures that:
a) we report the messags from a broken stage
b) we report any osbuild messages as well to catch e.g.
crashes that are not reported via the json progress
It is archived by creating a new build container fixture that is
deliberately broken, i.e:
a) the org.osbuild.selinux stage is replaced with a fake that
will echo some msgs and then error
b) osbuild itself is is wrapped around so that we can reliably
echo some canary strings before the real osbuild is executed