.github/workflows: trigger gitlab as soon as possible #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we gated the GitLab tests on the unit tests. However, these now take ~10 minutes, which is just annoying for engineers. This commit changes the trigger to fire immediately after the PR is updated. This should save our engineers 10 minutes on every push. Regarding higher infra costs: Engineers are more expensive. :P Signed-off-by: Ondřej Budai <[email protected]>
|
Something wrong with the workflow now that it's a separate file? |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 30+7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we gated the GitLab tests on the unit tests. However, these now take ~10 minutes, which is just annoying for engineers. This commit changes the trigger to fire immediately after the PR is updated. This should save our engineers 10 minutes on every push.
Regarding higher infra costs: Engineers are more expensive. :P