osbuild-worker: improve error "reason" in case of stage failures (HMS-1442) #4113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schuellerf
force-pushed
the
improve_stage_error_message
branch
from
eaa6ac2
to
d846b4d
Compare
bcl
reviewed
Apr 29, 2024
schuellerf
changed the title
schuellerf
commented
Apr 30, 2024
thozza
reviewed
May 1, 2024
schuellerf
force-pushed
the
improve_stage_error_message
branch
from
85feb6c
to
3828af2
Compare
schuellerf
force-pushed
the
improve_stage_error_message
branch
2 times, most recently
from
ed43026
to
5b2a520
Compare
bcl
force-pushed
the
improve_stage_error_message
branch
from
5b2a520
to
f33129b
Compare
mvo5
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Thank you for improving this! I wonder if we should take the opportunity (maybe in a followup if you prefer) to extract a helper here and write a test. The current Run() function is very long and does a lot of things so extracting a helper will not helper that much but it's a start. Wdyt about something like:
0001-osbuild-worker-extract-makeJobErrorFromOsbuildOutput.patch.txt
as a starting point, there is a lot of room for improvement here but this feels like we could build more on top (and also could be used as an example to e.g. extract the logging too etc.
But happy to do as a followup of course!
schuellerf
force-pushed
the
improve_stage_error_message
branch
2 times, most recently
from
42e0b17
to
f849321
Compare
schuellerf
force-pushed
the
improve_stage_error_message
branch
from
f849321
to
28aa517
Compare
|
Also fixes osbuild/images#727 |
schuellerf
force-pushed
the
improve_stage_error_message
branch
2 times, most recently
from
d84797c
to
3ccd4f5
Compare
schuellerf
force-pushed
the
improve_stage_error_message
branch
from
3ccd4f5
to
8028bbf
Compare
as now the .Reason is properly passed over - it was printed twice
schuellerf
force-pushed
the
improve_stage_error_message
branch
from
8028bbf
to
53a5707
Compare
mvo5
approved these changes
Jul 9, 2024
mvo5
added a commit
to mvo5/osbuild-composer
that referenced
this pull request
Jul 10, 2024
Small followup for osbuild#4113 (comment) Given that the failed stage is a relatively short string the `\n` seems unneccessary and quotes are enough.
thozza
pushed a commit
that referenced
this pull request
Jul 11, 2024
Small followup for #4113 (comment) Given that the failed stage is a relatively short string the `\n` seems unneccessary and quotes are enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve the error in the frontend from
to
There is no test framework to test changes like this, right?