-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packer: Fix installing worker RPMs in prod builds #4142
Conversation
Depsolve errors in the Packer job:
Sounds like some repos should be updated? |
It should be taking the osbuild commit SHA from |
I've added a commit which I believe should fix the issues we're seeing. |
We use --skip-tags rpmrepo_composer,rpmrepo_osbuild,rpmcopr for our prod builds. Thus, if we merge the following two tasks into one, no RPMs will be installed in prod builds, because --skip-tags joins multiple tags with OR. (IoW a task with tags == [rpmcopy, rpmrepo_osbuild] will not run with --skip-tags rpmrepo_osbuild). This is quite a horrible hack, but it will hopefully unbreak us for the time being.
Removing the rpmcopr tag as this is not a copr repo but a rpmrepo repo so it should have just the rpmrepo_osbuild tag.
I wonder if it isn't better to just invert the tag logic altogether #4150 |
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 30+7 days with no activity. |
We use --skip-tags rpmrepo_composer,rpmrepo_osbuild,rpmcopr for our prod
builds. Thus, if we merge the following two tasks into one, no RPMs will
be installed in prod builds, because --skip-tags joins multiple tags
with OR. (IoW a task with tags == [rpmcopy, rpmrepo_osbuild] will not
run with --skip-tags rpmrepo_osbuild).
This is quite a horrible hack, but it will hopefully unbreak us for the
time being.