Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packer: Fix installing worker RPMs in prod builds #4142

Closed
wants to merge 2 commits into from

Conversation

ondrejbudai
Copy link
Member

We use --skip-tags rpmrepo_composer,rpmrepo_osbuild,rpmcopr for our prod
builds. Thus, if we merge the following two tasks into one, no RPMs will
be installed in prod builds, because --skip-tags joins multiple tags
with OR. (IoW a task with tags == [rpmcopy, rpmrepo_osbuild] will not
run with --skip-tags rpmrepo_osbuild).

This is quite a horrible hack, but it will hopefully unbreak us for the
time being.

lucasgarfield
lucasgarfield previously approved these changes May 13, 2024
@jrusz
Copy link
Contributor

jrusz commented May 13, 2024

Depsolve errors in the Packer job:

fatal: [default]: FAILED! => {"changed": false, "failures": [], "msg": "Depsolve Error occured: \n Problem: cannot install the best candidate for the job\n  - nothing provides osbuild-depsolve-dnf >= 116 needed by osbuild-composer-worker-108-1.20240513gitc5e6055.el9.x86_64 from composer\n  - nothing provides osbuild >= 116 needed by osbuild-composer-worker-108-1.20240513gitc5e6055.el9.x86_64 from composer\n  - nothing provides osbuild-luks2 >= 116 needed by osbuild-composer-worker-108-1.20240513gitc5e6055.el9.x86_64 from composer\n  - nothing provides osbuild-lvm2 >= 116 needed by osbuild-composer-worker-108-1.20240513gitc5e6055.el9.x86_64 from composer\n  - nothing provides osbuild-ostree >= 116 needed by osbuild-composer-worker-108-1.20240513gitc5e6055.el9.x86_64 from composer", "rc": 1, "results": []}

Sounds like some repos should be updated?

@jrusz
Copy link
Contributor

jrusz commented May 13, 2024

It should be taking the osbuild commit SHA from Schutzfile and that was updated to v117 37995a7 so idk what's wrong

@jrusz
Copy link
Contributor

jrusz commented May 14, 2024

I've added a commit which I believe should fix the issues we're seeing.

ondrejbudai and others added 2 commits May 14, 2024 09:42
We use --skip-tags rpmrepo_composer,rpmrepo_osbuild,rpmcopr for our prod
builds. Thus, if we merge the following two tasks into one, no RPMs will
be installed in prod builds, because --skip-tags joins multiple tags
with OR. (IoW a task with tags == [rpmcopy, rpmrepo_osbuild] will not
run with --skip-tags rpmrepo_osbuild).

This is quite a horrible hack, but it will hopefully unbreak us for the
time being.
Removing the rpmcopr tag as this is not a copr repo but a rpmrepo repo
so it should have just the rpmrepo_osbuild tag.
@croissanne
Copy link
Member

I wonder if it isn't better to just invert the tag logic altogether #4150

Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 15, 2024
Copy link

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants