Advanced partitioning customizations (COMPOSER-2355) #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from osbuild/images:pkg/blueprint/filesystem_customizations_test.go These test features of the filesystem customizations: - Deserialization - Mountpoint policy validation The filesystem customization _might_ be removed from osbuild/images and osbuild-composer will be responsible for mapping the old customizations onto the new. Copying the tests over ensures that if and when we make this change, the functionality of old format is still tested.
osbuild/images -> achilleas-k/images@more-partitioning Update boot mode enum: Moved from images/pkg/distro to images/pkg/platform.
Add the new partitioning configs introduced in osbuild/images to the internal blueprint.
Due to the deeply nested structure of this new customization, it was simpler to make small single-purpose conversion functions for each layer, rather than nesting loops. Add to tests as well.
achilleas-k
changed the title
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in osbuild/images#926.
Updated customizations conversion and added to conversion tests.
TODO: