Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudapi depsolve (COMPOSER-2131) #4372

Closed
wants to merge 7 commits into from
Closed

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Sep 18, 2024

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as
    • submit a PR for the READMEs listed here
    • submit a PR for the osbuild.org website repository if this PR changed any behavior not covered by the automatically updated READMEs

@bcl
Copy link
Contributor Author

bcl commented Sep 18, 2024

  • needs tests
  • needs error response TODOs fixed

@ochosi ochosi changed the title cloudapi depsolve cloudapi depsolve (COMPOSER-2131) Sep 19, 2024
@bcl bcl marked this pull request as ready for review September 21, 2024 00:17
If included it overrides the architecture in the compose image request.

Related: RHEL-60125
This will allow depsolving blueprints and returning package metadata for
the dependencies.

Related: RHEL-60125
This function only depends on the Blueprint (cloudapi request type, not
the internal/blueprint) so move it to a function on that so that it can
be reused by other users of the cloudapi Blueprint.

Related: RHEL-60125
Related: RHEL-60125
In order to reuse PackageMetadata with DepsolveResponse and not include
unused fields this changes the sigmd5 entry to an optional field. This
doesn't effect the use of PackageMetadata in the Compose response since
it is always set, and it allows it to be omitted in the response for
depsolving.

Also adds a basic test for stagesToPackageMetadata

Related: RHEL-60125
This also adds an actual repository json file for the test-disro.
Without this the repo.ListDistros() function doesn't return any actual
distros.

Related: RHEL-60125
This converts the request's blueprint to an internal/blueprint,
optionally selects the blueprint's distro and arch to override the
host's and depsolves the blueprint.

Also adds mock dnfjson depsolving to the test framework. And tests for
the new behavior.

Resolves: RHEL-60125
@bcl
Copy link
Contributor Author

bcl commented Sep 27, 2024

Closing this since #4390 includes it.

@bcl bcl closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant