Remove image-info and use it from osbuild #4543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
achilleas-k
force-pushed
the
rm/image-info
branch
from
31b5146 to
a362c98
Compare
|
Needs new repo snapshots (#4542). |
thozza
reviewed
Jan 3, 2025
achilleas-k
force-pushed
the
rm/image-info
branch
from
a362c98 to
5ae129a
Compare
mvo5
previously approved these changes
Jan 6, 2025
thozza
reviewed
Jan 6, 2025
achilleas-k
force-pushed
the
rm/image-info
branch
from
5ae129a to
15e692c
Compare
thozza
reviewed
Jan 8, 2025
achilleas-k
force-pushed
the
rm/image-info
branch
from
15e692c to
9aa9af5
Compare
achilleas-k
force-pushed
the
rm/image-info
branch
from
c2f4054 to
5f1c88b
Compare
achilleas-k
force-pushed
the
rm/image-info
branch
from
5f1c88b to
1c6fc42
Compare
achilleas-k
force-pushed
the
rm/image-info
branch
from
1c6fc42 to
506be3c
Compare
|
Rebased and fixed conflicts |
Update osbuild commit ID to include image info, which now installs as /usr/bin/osbuild-image-info.
The image-info tool now lives in osbuild/osbuild.
achilleas-k
force-pushed
the
rm/image-info
branch
from
506be3c to
24e4c7b
Compare
Call the script without a path since it's now in the PATH. Drop the SELinux labelling workaround (chcon) from filesystem.sh and image_tests.sh. The packaged tool is already labelled correctly. Install osbuild-tools instead of osbuild-composer-tests in regression-old-worker-new-composer.sh to get osbuild-image-info.
achilleas-k
force-pushed
the
rm/image-info
branch
from
24e4c7b to
7fec5af
Compare
|
Missed one case where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image-info tool is now included in the osbuild repo and packaged in osbuild-tools. This PR removes the tool from this repository and updates all calls to it to use the one from osbuild, which installs to
/usr/bin/osbuild-image-info.