many: update for new reporegistry.New() api (c.f. pr#1179) #4603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
update-api-for-images-pr1179
branch
from
2839201 to
4c84c2b
Compare
mvo5
requested review from
thozza,
schuellerf and
supakeen
and removed request for
a team
supakeen
previously approved these changes
Feb 10, 2025
thozza
reviewed
Feb 11, 2025
mvo5
force-pushed
the
update-api-for-images-pr1179
branch
from
4c84c2b to
7b6d19e
Compare
schuellerf
force-pushed
the
update-api-for-images-pr1179
branch
from
7b6d19e to
c53ac1b
Compare
mvo5
force-pushed
the
update-api-for-images-pr1179
branch
from
c53ac1b to
1c64f80
Compare
|
@mvo5, there is now a merge conflict. Can you please take a look? Thanks! |
mvo5
force-pushed
the
update-api-for-images-pr1179
branch
2 times, most recently
from
e9ae4d0 to
3b40db1
Compare
|
@thozza Sorry, this grew again, the removal of fedora-39 from images caused another test failure in the cross-arch.sh so I had to bump images to the current version and vendor all dependencies etc. |
This commit updates osbuild-composer for the new API in images for the `reporegistry.New()`. The main incompatible change is that the `/repositories` part is not longer automatically added inside the library so we need to add it on the call-site. This needs osbuild/images#1179
Add more information when the cross-distro.sh test fails. Currently it prints: ``` DEBUG: ===== ALL_DISTROS ==== rhel-8 ... rhel-8 DEBUG: ===== ALL_EXPECTED_DISTROS ==== fedora-40 ... fedora-42 DEBUG: ===== ALL_REMAINDERS ==== rhel-8 .... rhel-8 DEBUG: ===== END ==== Some distros are missing! Missing distros: ``` But the most crucial information (i.e. what is installed) is missing from this debug print (it can be found in a different output but lets make it easy).
mvo5
force-pushed
the
update-api-for-images-pr1179
branch
from
3b40db1 to
78a06d1
Compare
This commit updates to images v0.117.0 so that the cross-distro.sh test works again (images removed fedora-39.json in main but the uses the previous version of images that includes fedora-39 so there is a mismatch (we should look into if there is a way to get github.com/osbuild/images@latest instead of main in the cross-arch test). It also updates all the vendor stuff that got pulled via the new images release (which is giantonormous). This update requires updating the Go version to 1.22.8
This commit fixes the failing TestGetImageRequests_BlueprintDistro test. It fails because fedora-39 is no longer part of the supported distros and can no longer be build. Move to fedora-42 so that we have a bit time before we need to update it again. It also updates TestGetImageRequests_NoRepositories to point to fedora-42.
achilleas-k
force-pushed
the
update-api-for-images-pr1179
branch
from
78a06d1 to
b53bd2f
Compare
|
I amended the commit that updates images to v0.117.0 to also update the Go version in |
This commit tweaks the `cross-build.sh` to checkout the last release tag of the images library instead of using main. The issue with using main is that there are many false positive errors when e.g. a new fedora release is added to main. Ideally it would use the tag of the vendored images library but this particular test looks at the rpm content so the information what version of images was used is not readily available (we could fix this but the workaround of this commit is hopefully sufficient).
achilleas-k
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates osbuild-composer for the new API in images for the
reporegistry.New(). The main incompatible change is that the/repositoriespart is not longer automatically added inside the library so we need to add it on the call-site.This needs osbuild/images#1179