Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/user-guide: document the new installer.modules customization #100

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

achilleas-k
Copy link
Member

@achilleas-k achilleas-k commented Jul 31, 2024

Introduced in osbuild/images#799
Added to bootc-image-builder in osbuild/bootc-image-builder#590

thozza
thozza previously approved these changes Aug 1, 2024
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

achilleas-k added a commit to achilleas-k/bootc-image-builder that referenced this pull request Aug 12, 2024
achilleas-k added a commit to achilleas-k/bootc-image-builder that referenced this pull request Aug 13, 2024
github-merge-queue bot pushed a commit to osbuild/bootc-image-builder that referenced this pull request Aug 14, 2024
@thozza
Copy link
Member

thozza commented Aug 28, 2024

@achilleas-k could be marked as ready, no?

@achilleas-k
Copy link
Member Author

The original version of this PR had the feature documented for osbuild-composer only. Right now, it's only supported in bootc-image-builder. I didn't manage to add it to osbuild-composer yet.

@achilleas-k achilleas-k marked this pull request as ready for review September 2, 2024 14:55
@achilleas-k
Copy link
Member Author

Marking ready. Will update the osbuild-composer part when it's added.

thozza
thozza previously approved these changes Sep 3, 2024
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/user-guide/01-blueprint-reference.md Outdated Show resolved Hide resolved
docs/user-guide/01-blueprint-reference.md Outdated Show resolved Hide resolved
docs/user-guide/01-blueprint-reference.md Outdated Show resolved Hide resolved
docs/user-guide/01-blueprint-reference.md Outdated Show resolved Hide resolved
achilleas-k and others added 2 commits September 3, 2024 11:07
Introduced in osbuild/images#799
Added to bootc-image-builder in osbuild/bootc-image-builder#590

The customization is currently only available in bootc-image-builder.

Co-authored-by: Florian Schüller <[email protected]>
Copy link
Contributor

@schuellerf schuellerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, lgtm

Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew that Florian will have some useful comments 😇 LGTM!

@thozza thozza merged commit 57c8871 into main Sep 3, 2024
2 checks passed
@thozza thozza deleted the anaconda-modules branch September 3, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants