-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/user-guide: document the new installer.modules customization #100
Conversation
113c47f
to
2e346d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Based on the upstream blueprint documentation: osbuild/osbuild.github.io#100
Based on the upstream blueprint documentation: osbuild/osbuild.github.io#100
Based on the upstream blueprint documentation: osbuild/osbuild.github.io#100
@achilleas-k could be marked as ready, no? |
6e908ea
to
e0dcaa8
Compare
The original version of this PR had the feature documented for osbuild-composer only. Right now, it's only supported in bootc-image-builder. I didn't manage to add it to osbuild-composer yet. |
Marking ready. Will update the osbuild-composer part when it's added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Florian Schüller <[email protected]>
Introduced in osbuild/images#799 Added to bootc-image-builder in osbuild/bootc-image-builder#590 The customization is currently only available in bootc-image-builder. Co-authored-by: Florian Schüller <[email protected]>
e0dcaa8
to
5410f29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I knew that Florian will have some useful comments 😇 LGTM!
Introduced in osbuild/images#799
Added to bootc-image-builder in osbuild/bootc-image-builder#590