Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user-guide: new chapter about firstboot #120

Merged
merged 1 commit into from
Sep 26, 2024
Merged

user-guide: new chapter about firstboot #120

merged 1 commit into from
Sep 26, 2024

Conversation

lzap
Copy link
Contributor

@lzap lzap commented Sep 17, 2024

SSIA

ochosi
ochosi reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo? If so it's there thrice

docs/user-guide/08-firstboot.md Outdated Show resolved Hide resolved
ochosi
ochosi requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some errors in the markdown (which is why the test-build fails).

@lzap
Copy link
Contributor Author

lzap commented Sep 20, 2024

Fixed.

@lzap
Copy link
Contributor Author

lzap commented Sep 25, 2024

Rebased @ochosi

@lzap lzap requested a review from ochosi September 26, 2024 08:32
ochosi
ochosi approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you <3

@ochosi ochosi merged commit 03b1129 into osbuild:main Sep 26, 2024
2 checks passed
@lzap lzap deleted the firstboot branch September 26, 2024 15:06
@lzap
Copy link
Contributor Author

lzap commented Sep 26, 2024

I am surprised it rendered fine, I was pretty sure I messed up, I mean, I would have to do npm install which I wanted to avoid... :-)

https://osbuild.org/docs/user-guide/firstboot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ochosi ochosi ochosi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lzap @ochosi