Adding cloudapi support to composer-cli (COMPOSER-2131) #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochosi
changed the title
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
@bcl this change looks to be interesting but GitHub again stalled it. |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
- PostRaw and PostJSON functions - GetJSON function - Exists function - ErrorToString function to parse a cloudapi error json response into a string Related: RHEL-60148
Related: RHEL-60148
This allows you to build weldr-client with a custom version, eg. for
development so that the NEVRA will always be greater than the last
build.
Use it like this:
BASEVER=$(grep ^VERSION Makefile | awk '{ print $3 }')
VERSION=$BASEVER.$(date +%Y%m%d%H%M) make build-in-podman
This will check to see if the cloudapi socket is available, and if so it will show the Cloud API version number and name of the service. Related: RHEL-60148
Retrieve the cloud API's openapi info. Related: RHEL-60148
This function uses the cloud API to start a compose using a blueprint that is included in the compose request instead of one that has been previously uploaded. Related: RHEL-60124
When a local file is used in place of the blueprint name composer-cli will use the cloud API to upload the blueprint and start the compose. Currently this expects the osbuild-composer server to have the 'localsave' option enabled in its osbuild-composer.service file. Resolves: RHEL-60124
The upload options are passed via the cloud API's image request ImageOptions: https://github.com/osbuild/osbuild-composer/blob/main/internal/cloudapi/v2/openapi.v2.yml#L795 the cloud client code does not do any validation of the format or content, that is all handled by the server which will return an error describing what went wrong if there is a problem. Related: RHEL-60124
The upload format for the cloud API server is different from that used by the weldr API. It is described in the cloud API's openapi schema document in the UploadOptions section: https://github.com/osbuild/osbuild-composer/blob/main/internal/cloudapi/v2/openapi.v2.yml#L1015 Related: RHEL-60124
The ExecutionError already prints 'ERROR' so there is no need for it in the strings passed to it. Related: RHEL-60148
Related: RHEL-60123
Related: RHEL-60123
Related: RHEL-60148
The composes built with the cloud API are not stored in the weldr API store so the UUID from the user may belong to one or the other. Check cloud API first, then weldr API and return the weldr API error if it is not found in either place. Note that the result printed is different. Cloud API uses 'success' and 'failure' and WELDR API uses 'FINISHED' and 'FAILED'. Related: RHEL-60124
Related: RHEL-60123
Currently the amount of information available for cloud composes is very limited compared to the WELDR API. Related: RHEL-60123
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
Splitting into multiple PRs. Part 1 is #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is a draft, and there are some significant pieces missing from the cloudapi (that I will cover in #133). This code could also use some tests :) But it does provide a basic framework for using the cloudapi.
If osbuild-composer has local save enabled you can use this to start a compose using the cloudapi and a blueprint file without uploading it to the store first. uploading might also work, but there are a number of limitations preventing easy testing of it that can also be discussed in #133
Basically, this is a starting point for moving commands to cloudapi.