Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: adds fixes to support release and dependency updates for v1 #15

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Jan 9, 2025

CI and release related cleanup

Closes #13
Closes #18

For v1 module

Tested locally with act

@jpower432 jpower432 marked this pull request as ready for review January 24, 2025 16:48
@jpower432 jpower432 marked this pull request as draft January 31, 2025 15:04
Files under the testdata directory have a colon characters
which results in an error when trying to import the module with
`go get`. Per Go documentation, adding an empty go.mod to tesdata
can keep these files from being added to the module zip.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 added the v1 Related to Go Module v1 label Jan 31, 2025
@jpower432 jpower432 changed the title ci: updates version of Go in goreleaser GH job ci: adds fixes to support release and dependency updates for v1 Jan 31, 2025
@jpower432 jpower432 force-pushed the ci/fix-goreleaser-v1 branch from 0dba9db to 8599eca Compare January 31, 2025 17:53
@jpower432 jpower432 marked this pull request as ready for review January 31, 2025 18:12
@jpower432 jpower432 requested a review from yana1205 January 31, 2025 18:12
Copy link
Contributor

@yana1205 yana1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: adds an empty go.mod to testdata directory

Thank you for catching this issue and providing a solution!

@jpower432 jpower432 merged commit da9f5c3 into oscal-compass:v1 Feb 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1 Related to Go Module v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants