Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds assessment results generation #47

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gvauter
Copy link
Contributor

@gvauter gvauter commented Feb 12, 2025

Adds new reporter for generating OSCAL assessment results from PVP policy results.

gvauter and others added 2 commits January 31, 2025 14:23
#9)

* feat: initial work to create assessment results generator

Signed-off-by: George Vauter <[email protected]>

* fix: make c2p importable

When trying import C2P Go, the operation fails because of the
":" character in the testdata is not valid against go
module.CheckFilePath. Add an empty go.mod will exlude the testdata
when importing the top-level module.

Signed-off-by: Jennifer Power <[email protected]>

* feat: adds findings to assessment results

Signed-off-by: George Vauter <[email protected]>

* fix: updates code for changes in oscal-sdk-go

Signed-off-by: Jennifer Power <[email protected]>

* add unit tests for better coverage of the reporter helper funcs

Signed-off-by: George Vauter <[email protected]>

* add basic logger with info messages

Signed-off-by: George Vauter <[email protected]>

* add test logger

Signed-off-by: George Vauter <[email protected]>

* implement c2p config in reporter

Signed-off-by: George Vauter <[email protected]>

* feat: adds Settings to PluginManager operations

To allow customization based on implementations for specific
compliance frameworks, a Settings input has been added to GeneratePolicy and
AggregateResults methods to alter the RuleSets passed to plugins based on
settings from a given control implementation.

Signed-off-by: Jennifer Power <[email protected]>

* accept pvp results value instead of pointer

Signed-off-by: George Vauter <[email protected]>

* fix: address pr feedback

Signed-off-by: George Vauter <[email protected]>

* fix: don't add findings to result if none were generated

Signed-off-by: George Vauter <[email protected]>

---------

Signed-off-by: George Vauter <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Co-authored-by: Jennifer Power <[email protected]>
@gvauter gvauter marked this pull request as draft February 12, 2025 19:34
@jpower432 jpower432 linked an issue Feb 12, 2025 that may be closed by this pull request
@gvauter gvauter force-pushed the feat/assessment-results branch from 7b023ae to 477a075 Compare February 18, 2025 19:18
@gvauter gvauter marked this pull request as ready for review February 18, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Produce a single OSCAL Assessment Result
1 participant