-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds transformation from component definitions to assessment plans #36
feat: adds transformation from component definitions to assessment plans #36
Conversation
Support for AssessmentPlan generation is added with inputs that are intentionally flexible to allow AssessmentPlans to be populated from SSPs or directly from ComponentDefinition data, if desired. Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
All top-level OSCAL models use Metadata, this change centralizes the creation of new metadata for consistency. Signed-off-by: Jennifer Power <[email protected]>
All factory functions for creating different Setting types are grouped together to make them easier to find. Statement-level support is also added to ImplementationSettings and the factory function for creating Settings from requirements is made private because there is some additional processing from the implementation perspective that makes the standalone requirement Setting incomplete. Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one small thought for a future task.
@vikas-agarwal76 @degenaro @yana1205 @butler54
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a minor comment. Tested locally.
@jpower432 I am not sure if acitivty corrsponds to each rule or the policy execution (which checks multiple rules). Same with associated activities in Tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vikas-agarwal76 documenting the outcome of our discussion here: The rule-driven activity approach is acceptable for now. If needed, we can refine Assessment Plan approach as it gets more use. |
Signed-off-by: Jennifer Power <[email protected]>
Description
The main feature added in the
ComponentDefinitionsToAssessmentPlan
function that will take one or more OSCAL Component Definitions are populate an Assessment Plan.models
package was added to support logic around specific OSCAL models or subsets (compliance-trestle
partial equivalent)transformers
package was added with logic for OSCAL to OSCAL transformations (compliance-trestle
equivalent, but scoped to OSCAL-to-OSCAL only)Closes #32
To support oscal-compass/compliance-to-policy-go#43
Review Hints
Settings
interface is remove and theRequirementsSettings
struct is renamed toSettings
because all other implementation were using the same type and methods to support the logic. An interface is not needed (yet) and can be added later if the use case arises.How has this been tested?
Types of changes
Quality assurance (all should be covered).