-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use different scratchspace dir for every session #1083
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
+ Coverage 74.47% 74.59% +0.12%
==========================================
Files 55 55
Lines 4587 4593 +6
==========================================
+ Hits 3416 3426 +10
+ Misses 1171 1167 -4
|
This currently does not create a new scratch folder for every session, but only every time precompilation runs. Do you have an idea on how to fix that? |
This is IMHO the wrong approach. First off, scratchspaces live too long. IIRC by default 30 days. I sometimes create dozens of these on a single day. They could and should all be deleted right afterwards, hence And the second issue is precisely the one you run into: the scratch space is meant to be something that is created during precompilation. Hence my idea to have a single long-lived scratch space which we just use as a kind of temp dir. |
I see you point. The only problem with |
Exactly. That's why I wanted to put the dates in there, so that at least I can do something like But actually, perhaps we also use a scratch space name that involves the current month, so something like |
sounds good to me |
closing in favor of #1079 |
This implements my suggestion from #1079 (comment).
The other parts of #1079 (e.g. regarding the
sysinfo
handling) are not covered here and instead may be split off into their own PR or rebased or...