Skip to content

Add Greenfunctions table for E8c2 #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SoongNoonien
Copy link
Member

This file is based on a test file from @frankluebeck. It should be correct now. But not very elegant.

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (4d4dcc0) to head (c862e15).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files          13       13           
  Lines         905      905           
=======================================
  Hits          859      859           
  Misses         46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin
Copy link
Member

As you just pointed out to me orally, it would be good to have an info string in this. Perhaps @frankluebeck can provide us with a few lines about the origin of this table. Also, what does "c2" mean in "E8c2" ?

@frankluebeck
Copy link

This file is really just intended as a temporary larger example for testing.

Of course, the information entry could be extended a bit, say:

information = "generalized Green functions for E_8(q) with q = 2 mod 30, computed by Frank Lübeck"

I cannot make further comments because after a git pull the package does no longer compile (I get error messages saying that ConformanceTests is not defined). So, I cannot test the current version.

When I understand the code in E8c2.jl correctly, this version of the file stores all entries as polynomials in the square root of q. But almost all entries are polynomials in q. So, almost all polynomials are just blown up, need double space and the arithmetic is less efficient.

Isn't there a way to compute in a quadratic extension of K[q] with most entries in this base ring?
Does anyone think about having Puiseux polynomials in Oscar?

@SoongNoonien
Copy link
Member Author

This file is really just intended as a temporary larger example for testing.

So it isn't of any actual interest?

I cannot make further comments because after a git pull the package does no longer compile (I get error messages saying that ConformanceTests is not defined). So, I cannot test the current version.

It will most certainly compile after a ]up you need at least OSCAR 1.3.

@fingolfin
Copy link
Member

So, almost all polynomials are just blown up, need double space and the arithmetic is less efficient.

Multivariate polynomials are stored sparsely and so only one int entry in each exponent vector gets doubled.

@SoongNoonien
Copy link
Member Author

Multivariate polynomials are stored sparsely and so only one int entry in each exponent vector gets doubled.

Unfortunately, we are dealing with univariate polynomials in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants