Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter and upgrade OpenCC data #1486

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

Bambooin
Copy link
Collaborator

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #
Fixes #

Feature

Describe features of this pull request

There are unrelated files in asset folder.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        app/src/main/assets/shared/opencc/BUILD.bazel
        app/src/main/assets/shared/opencc/DictionaryTest.cpp
  • fix: filter opencc data file
  • chore: upgrade opencc data

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@WhiredPlanck
Copy link
Collaborator

WhiredPlanck commented Oct 11, 2024

I think we shall install OpenCC's data by Gradle scripts when build the packages and not add them to git in the future, and then it saves us the extra time needed to update and maintain them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants