-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation about k8s on a origin #10
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @biozit, thanks for the PR, it's helpful to see what you're working on but as I discussed, my team needs to develop a broader strategy wrt how we document/support Kubernetes deployments so we won't be merging this just yet
command: [ "sleep" ] | ||
args: [ "infinity" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
command
in a deployment refers to the ENTRYPOINT
so this will result in a container that starts up and does nothing.
### Running on origin kubenetes with systemd | ||
|
||
TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to give systemd-related Kubernetes instructions – once the deployment is in k8s, users shouldn't have to worry about maintaining a persistent service via systemd!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the OSDF caches, we can use supervisorctl restart stash-cache and it is useful during the administration process. We are using the opensciencegrid/stash-cache:3.6-testing-20220414-1721 image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, that's within the container using supervisord. Systemd would only really be used on bare metal to manage services, which is unnecessary with k8s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this topic should be supervisord
I don't think this is necessary: the container should start supervisord and thus the relevant services. The operator should ideally not have to interact with supervisord at all!
Sorry, this topic should be supervisord
*--Fábio Andrijauskas*
…On Tue, Jun 28, 2022 at 11:03 AM Brian Lin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/data/stashcache/run-stash-origin-container.md
<#10 (comment)>:
> +### Running on origin kubenetes with systemd
+TODO
Right, that's within the container using supervisord. Systemd would only
really be used on bare metal to manage services, which is unnecessary with
k8s
—
Reply to this email directly, view it on GitHub
<#10 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEEH76H5GN7AECTCBYJP5DVRM46HANCNFSM5Z7ROIVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Should we add some instructions for the monitoring configuration?
On Tue, Jun 28, 2022 at 12:12 PM Brian Lin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/data/stashcache/run-stash-origin-container.md
<#10 (comment)>:
> +### Running on origin kubenetes with systemd
+TODO
Sorry, this topic should be supervisord
I don't think this is necessary: the container should start supervisord
and thus the relevant services. The operator should ideally not have to
interact with supervisord at all!
—
Reply to this email directly, view it on GitHub
<#10 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEEH7ZELNSSJA3PBIOQITDVRNFDRANCNFSM5Z7ROIVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*--Fábio Andrijauskas*
|
No description provided.