Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation about k8s on a origin #10

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

biozit
Copy link

@biozit biozit commented Jun 27, 2022

No description provided.

Copy link
Contributor

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @biozit, thanks for the PR, it's helpful to see what you're working on but as I discussed, my team needs to develop a broader strategy wrt how we document/support Kubernetes deployments so we won't be merging this just yet

Comment on lines +100 to +101
command: [ "sleep" ]
args: [ "infinity" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

command in a deployment refers to the ENTRYPOINT so this will result in a container that starts up and does nothing.

Comment on lines +169 to +171
### Running on origin kubenetes with systemd

TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to give systemd-related Kubernetes instructions – once the deployment is in k8s, users shouldn't have to worry about maintaining a persistent service via systemd!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the OSDF caches, we can use supervisorctl restart stash-cache and it is useful during the administration process. We are using the opensciencegrid/stash-cache:3.6-testing-20220414-1721 image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that's within the container using supervisord. Systemd would only really be used on bare metal to manage services, which is unnecessary with k8s

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this topic should be supervisord

I don't think this is necessary: the container should start supervisord and thus the relevant services. The operator should ideally not have to interact with supervisord at all!

@biozit
Copy link
Author

biozit commented Jun 28, 2022 via email

@biozit
Copy link
Author

biozit commented Jun 30, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants