Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add payload to formatter #347

Closed
wants to merge 1 commit into from
Closed

add payload to formatter #347

wants to merge 1 commit into from

Conversation

oshai
Copy link
Owner

@oshai oshai commented Aug 6, 2023

No description provided.

@oshai oshai mentioned this pull request Aug 6, 2023
@robertfmurdock
Copy link
Contributor

x-posted from issue:

Makes sense to me. Would it make sense for the message to be passed through as the simple string then instead of the function arg? Or both of them be passed as function args? It seems slightly inconsistent for one to be a function producer and the other a flat map, but if there's an underlying mechanical reason that'd be fine

@oshai
Copy link
Owner Author

oshai commented Aug 9, 2023

@robertfmurdock see the planned changes in #350

@oshai
Copy link
Owner Author

oshai commented Aug 10, 2023

Fixed in #350

@oshai oshai closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants