Add Kotlin/Wasm (JS browser) support #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshai
reviewed
Jan 14, 2024
src/wasmJsMain/kotlin/io/github/oshai/kotlinlogging/ConsoleOutputAppender.kt
Outdated
Show resolved
Hide resolved
|
Thank you for the contribution! |
StefanLobbenmeier
referenced
this pull request
in StefanLobbenmeier/yt-dlp-compose
Jan 21, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging) | `5.1.1` -> `6.0.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oshai/kotlin-logging (io.github.oshai:kotlin-logging-jvm)</summary> ### [`v6.0.3`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.3) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.2...6.0.3) #### What's Changed - Add Kotlin/Wasm (JS browser) support by [@​AzimMuradov](https://togithub.com/AzimMuradov) in [https://github.com/oshai/kotlin-logging/pull/388](https://togithub.com/oshai/kotlin-logging/pull/388) - Bump com.diffplug.spotless from 6.23.3 to 6.24.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/390](https://togithub.com/oshai/kotlin-logging/pull/390) - Bump actions/upload-pages-artifact from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/391](https://togithub.com/oshai/kotlin-logging/pull/391) - Bump actions/deploy-pages from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/392](https://togithub.com/oshai/kotlin-logging/pull/392) - Bump actions/cache from 3.3.2 to 3.3.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/393](https://togithub.com/oshai/kotlin-logging/pull/393) - Log marker and stacktrace on Darwin by [@​Gaming32](https://togithub.com/Gaming32) in [https://github.com/oshai/kotlin-logging/pull/379](https://togithub.com/oshai/kotlin-logging/pull/379) #### New Contributors - [@​Gaming32](https://togithub.com/Gaming32) made their first contribution in [https://github.com/oshai/kotlin-logging/pull/379](https://togithub.com/oshai/kotlin-logging/pull/379) **Full Changelog**: oshai/kotlin-logging@6.0.2...6.0.3 ### [`v6.0.2`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.2) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.1...6.0.2) #### What's Changed - Bump multiplatform from 1.9.21 to 1.9.22 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/385](https://togithub.com/oshai/kotlin-logging/pull/385) - Remove detekt by [@​AzimMuradov](https://togithub.com/AzimMuradov) in [https://github.com/oshai/kotlin-logging/pull/387](https://togithub.com/oshai/kotlin-logging/pull/387) - Add workflow to publish Dokka HTML docs to project site by [@​EdricChan03](https://togithub.com/EdricChan03) in [https://github.com/oshai/kotlin-logging/pull/383](https://togithub.com/oshai/kotlin-logging/pull/383) #### New Contributors - [@​EdricChan03](https://togithub.com/EdricChan03) made their first contribution in [https://github.com/oshai/kotlin-logging/pull/383](https://togithub.com/oshai/kotlin-logging/pull/383) **Full Changelog**: oshai/kotlin-logging@6.0.1...6.0.2 ### [`v6.0.1`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.1) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.0...6.0.1) #### What's Changed - Bump com.diffplug.spotless from 6.22.0 to 6.23.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/377](https://togithub.com/oshai/kotlin-logging/pull/377) - Bump actions/setup-java from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/376](https://togithub.com/oshai/kotlin-logging/pull/376) - Bump org.jetbrains.dokka from 1.8.20 to 1.9.10 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/366](https://togithub.com/oshai/kotlin-logging/pull/366) **Full Changelog**: oshai/kotlin-logging@6.0.0...6.0.1 ### [`v6.0.0`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.0) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/5.1.4...6.0.0) #### What's Changed - Update Kotlin to 1.9.21 by [@​AzimMuradov](https://togithub.com/AzimMuradov) in [https://github.com/oshai/kotlin-logging/pull/380](https://togithub.com/oshai/kotlin-logging/pull/380) #### New Contributors - [@​AzimMuradov](https://togithub.com/AzimMuradov) made their first contribution in [https://github.com/oshai/kotlin-logging/pull/380](https://togithub.com/oshai/kotlin-logging/pull/380) **Full Changelog**: oshai/kotlin-logging@5.1.2...6.0.0 ### [`v5.1.4`](https://togithub.com/oshai/kotlin-logging/releases/tag/5.1.4) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/5.1.1...5.1.4) #### What's Changed - fix - protect from uncontrolled format string by [@​oshai](https://togithub.com/oshai) in [https://github.com/oshai/kotlin-logging/pull/381](https://togithub.com/oshai/kotlin-logging/pull/381) **Full Changelog**: oshai/kotlin-logging@5.1.1...5.1.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/StefanLobbenmeier/yt-dlp-compose). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuMTM1LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
nikclayton
referenced
this pull request
in pachli/pachli-android
Mar 4, 2024
….0.3 (#362) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging) | `5.1.4` -> `6.0.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging) | `6.0.1` -> `6.0.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>oshai/kotlin-logging (io.github.oshai:kotlin-logging-jvm)</summary> ### [`v6.0.3`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.3) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.2...6.0.3) #### What's Changed - Add Kotlin/Wasm (JS browser) support by [@​AzimMuradov](https://togithub.com/AzimMuradov) in [https://github.com/oshai/kotlin-logging/pull/388](https://togithub.com/oshai/kotlin-logging/pull/388) - Bump com.diffplug.spotless from 6.23.3 to 6.24.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/390](https://togithub.com/oshai/kotlin-logging/pull/390) - Bump actions/upload-pages-artifact from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/391](https://togithub.com/oshai/kotlin-logging/pull/391) - Bump actions/deploy-pages from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/392](https://togithub.com/oshai/kotlin-logging/pull/392) - Bump actions/cache from 3.3.2 to 3.3.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/393](https://togithub.com/oshai/kotlin-logging/pull/393) - Log marker and stacktrace on Darwin by [@​Gaming32](https://togithub.com/Gaming32) in [https://github.com/oshai/kotlin-logging/pull/379](https://togithub.com/oshai/kotlin-logging/pull/379) #### New Contributors - [@​Gaming32](https://togithub.com/Gaming32) made their first contribution in [https://github.com/oshai/kotlin-logging/pull/379](https://togithub.com/oshai/kotlin-logging/pull/379) **Full Changelog**: oshai/kotlin-logging@6.0.2...6.0.3 ### [`v6.0.2`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.2) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.1...6.0.2) #### What's Changed - Bump multiplatform from 1.9.21 to 1.9.22 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/385](https://togithub.com/oshai/kotlin-logging/pull/385) - Remove detekt by [@​AzimMuradov](https://togithub.com/AzimMuradov) in [https://github.com/oshai/kotlin-logging/pull/387](https://togithub.com/oshai/kotlin-logging/pull/387) - Add workflow to publish Dokka HTML docs to project site by [@​EdricChan03](https://togithub.com/EdricChan03) in [https://github.com/oshai/kotlin-logging/pull/383](https://togithub.com/oshai/kotlin-logging/pull/383) #### New Contributors - [@​EdricChan03](https://togithub.com/EdricChan03) made their first contribution in [https://github.com/oshai/kotlin-logging/pull/383](https://togithub.com/oshai/kotlin-logging/pull/383) **Full Changelog**: oshai/kotlin-logging@6.0.1...6.0.2 ### [`v6.0.1`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.1) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.0...6.0.1) #### What's Changed - Bump com.diffplug.spotless from 6.22.0 to 6.23.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/377](https://togithub.com/oshai/kotlin-logging/pull/377) - Bump actions/setup-java from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/376](https://togithub.com/oshai/kotlin-logging/pull/376) - Bump org.jetbrains.dokka from 1.8.20 to 1.9.10 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/366](https://togithub.com/oshai/kotlin-logging/pull/366) **Full Changelog**: oshai/kotlin-logging@6.0.0...6.0.1 ### [`v6.0.0`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.0) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/5.1.4...6.0.0) #### What's Changed - Update Kotlin to 1.9.21 by [@​AzimMuradov](https://togithub.com/AzimMuradov) in [https://github.com/oshai/kotlin-logging/pull/380](https://togithub.com/oshai/kotlin-logging/pull/380) #### New Contributors - [@​AzimMuradov](https://togithub.com/AzimMuradov) made their first contribution in [https://github.com/oshai/kotlin-logging/pull/380](https://togithub.com/oshai/kotlin-logging/pull/380) **Full Changelog**: oshai/kotlin-logging@5.1.2...6.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/pachli/pachli-android). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solves #306.
No Node.js support for now, as it requires a canary Node.js version (21.0.0-v8-canary202309143a48826a08 or newer).
No WASI support also. Considering the raw state of Kotlin WASI, this currently seems too hard to implement.
Overall, this is a fairly simple implementation based on the
jsMainandjsTestmodules. I hope this will be ok as a first solution, just to provide initial support for WASM.