Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent Logging: Allow nullable values #402

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

Zack-Freedman-Thoughtworks

References: #400 (comment)

Example:

Example:

logger.atError {
    this.message = "Failed to make a good example: ${throwable.message}."
    this.cause = throwable
    this.payload = mapOf(
        "itemOne" to headers.getNullableThing(),
    )
}

Allows the value in the payload to be nullable. It seems that the code referencing the payloads are are written in Java so it is harder to know if this will lead to a null pointer exception or other troubles with possible loggers but the tests pass.

@oshai
Copy link
Owner

oshai commented Mar 6, 2024

From code checks I did I think the Java frameworks allow values to be null.

@oshai oshai merged commit 779c6ec into oshai:master Mar 8, 2024
4 of 5 checks passed
@oshai
Copy link
Owner

oshai commented Mar 8, 2024

Thanks!

renovate bot referenced this pull request in StefanLobbenmeier/yt-dlp-compose Apr 6, 2024
…33)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging)
| `6.0.3` -> `6.0.4` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.oshai:kotlin-logging-jvm/6.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.oshai:kotlin-logging-jvm/6.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.oshai:kotlin-logging-jvm/6.0.3/6.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.oshai:kotlin-logging-jvm/6.0.3/6.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>oshai/kotlin-logging
(io.github.oshai:kotlin-logging-jvm)</summary>

###
[`v6.0.4`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.4)

[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.3...6.0.4)

#### What's Changed

- Bump actions/cache from 3.3.3 to 4.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/oshai/kotlin-logging/pull/395](https://togithub.com/oshai/kotlin-logging/pull/395)
- Fluent Logging: Allow nullable values by
[@&#8203;Zack-Freedman-Thoughtworks](https://togithub.com/Zack-Freedman-Thoughtworks)
in
[https://github.com/oshai/kotlin-logging/pull/402](https://togithub.com/oshai/kotlin-logging/pull/402)
- Bump multiplatform from 1.9.22 to 1.9.23 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/oshai/kotlin-logging/pull/405](https://togithub.com/oshai/kotlin-logging/pull/405)
- Bump org.jetbrains.dokka from 1.9.10 to 1.9.20 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/oshai/kotlin-logging/pull/406](https://togithub.com/oshai/kotlin-logging/pull/406)
- Bump actions/cache from 4.0.0 to 4.0.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/oshai/kotlin-logging/pull/403](https://togithub.com/oshai/kotlin-logging/pull/403)
- Bump com.diffplug.spotless from 6.24.0 to 6.25.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/oshai/kotlin-logging/pull/397](https://togithub.com/oshai/kotlin-logging/pull/397)
- allow only markers being supplied by
[@&#8203;ewoelfel](https://togithub.com/ewoelfel) in
[https://github.com/oshai/kotlin-logging/pull/408](https://togithub.com/oshai/kotlin-logging/pull/408)
- Upgrade ktfmt to version 0.47 by
[@&#8203;mlewe](https://togithub.com/mlewe) in
[https://github.com/oshai/kotlin-logging/pull/415](https://togithub.com/oshai/kotlin-logging/pull/415)
- Allow supplying org.slf4j.Marker by
[@&#8203;mlewe](https://togithub.com/mlewe) in
[https://github.com/oshai/kotlin-logging/pull/414](https://togithub.com/oshai/kotlin-logging/pull/414)

#### New Contributors

-
[@&#8203;Zack-Freedman-Thoughtworks](https://togithub.com/Zack-Freedman-Thoughtworks)
made their first contribution in
[https://github.com/oshai/kotlin-logging/pull/402](https://togithub.com/oshai/kotlin-logging/pull/402)
- [@&#8203;ewoelfel](https://togithub.com/ewoelfel) made their first
contribution in
[https://github.com/oshai/kotlin-logging/pull/408](https://togithub.com/oshai/kotlin-logging/pull/408)
- [@&#8203;mlewe](https://togithub.com/mlewe) made their first
contribution in
[https://github.com/oshai/kotlin-logging/pull/415](https://togithub.com/oshai/kotlin-logging/pull/415)

**Full Changelog**:
oshai/kotlin-logging@6.0.3...6.0.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/StefanLobbenmeier/yt-dlp-compose).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nikclayton referenced this pull request in pachli/pachli-android Apr 10, 2024
….0.4 (#605)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging)
| `6.0.3` -> `6.0.4` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.oshai:kotlin-logging-jvm/6.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.oshai:kotlin-logging-jvm/6.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.oshai:kotlin-logging-jvm/6.0.3/6.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.oshai:kotlin-logging-jvm/6.0.3/6.0.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>oshai/kotlin-logging
(io.github.oshai:kotlin-logging-jvm)</summary>

###
[`v6.0.4`](https://togithub.com/oshai/kotlin-logging/releases/tag/6.0.4)

[Compare
Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.3...6.0.4)

#### What's Changed

- Bump actions/cache from 3.3.3 to 4.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/oshai/kotlin-logging/pull/395](https://togithub.com/oshai/kotlin-logging/pull/395)
- Fluent Logging: Allow nullable values by
[@&#8203;Zack-Freedman-Thoughtworks](https://togithub.com/Zack-Freedman-Thoughtworks)
in
[https://github.com/oshai/kotlin-logging/pull/402](https://togithub.com/oshai/kotlin-logging/pull/402)
- Bump multiplatform from 1.9.22 to 1.9.23 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/oshai/kotlin-logging/pull/405](https://togithub.com/oshai/kotlin-logging/pull/405)
- Bump org.jetbrains.dokka from 1.9.10 to 1.9.20 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/oshai/kotlin-logging/pull/406](https://togithub.com/oshai/kotlin-logging/pull/406)
- Bump actions/cache from 4.0.0 to 4.0.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/oshai/kotlin-logging/pull/403](https://togithub.com/oshai/kotlin-logging/pull/403)
- Bump com.diffplug.spotless from 6.24.0 to 6.25.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/oshai/kotlin-logging/pull/397](https://togithub.com/oshai/kotlin-logging/pull/397)
- allow only markers being supplied by
[@&#8203;ewoelfel](https://togithub.com/ewoelfel) in
[https://github.com/oshai/kotlin-logging/pull/408](https://togithub.com/oshai/kotlin-logging/pull/408)
- Upgrade ktfmt to version 0.47 by
[@&#8203;mlewe](https://togithub.com/mlewe) in
[https://github.com/oshai/kotlin-logging/pull/415](https://togithub.com/oshai/kotlin-logging/pull/415)
- Allow supplying org.slf4j.Marker by
[@&#8203;mlewe](https://togithub.com/mlewe) in
[https://github.com/oshai/kotlin-logging/pull/414](https://togithub.com/oshai/kotlin-logging/pull/414)

#### New Contributors

-
[@&#8203;Zack-Freedman-Thoughtworks](https://togithub.com/Zack-Freedman-Thoughtworks)
made their first contribution in
[https://github.com/oshai/kotlin-logging/pull/402](https://togithub.com/oshai/kotlin-logging/pull/402)
- [@&#8203;ewoelfel](https://togithub.com/ewoelfel) made their first
contribution in
[https://github.com/oshai/kotlin-logging/pull/408](https://togithub.com/oshai/kotlin-logging/pull/408)
- [@&#8203;mlewe](https://togithub.com/mlewe) made their first
contribution in
[https://github.com/oshai/kotlin-logging/pull/415](https://togithub.com/oshai/kotlin-logging/pull/415)

**Full Changelog**:
oshai/kotlin-logging@6.0.3...6.0.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/pachli/pachli-android).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants