Upgraded Kotlin to 2.0.0 #428

severn-everett · 2024-05-23T14:36:29Z

No description provided.

oshai · 2024-05-23T15:10:51Z

build.gradle.kts

-        apiVersion.set(KotlinVersion.KOTLIN_1_9)
-        languageVersion.set(KotlinVersion.KOTLIN_1_9)
+        apiVersion.set(KotlinVersion.KOTLIN_2_0)
+        languageVersion.set(KotlinVersion.KOTLIN_2_0)

        freeCompilerArgs.add("-Xexpect-actual-classes")


is this still required? -Xexpect-actual-classes

https://kotlinlang.org/docs/multiplatform-expect-actual.html#expected-and-actual-classes

Sounds like they still require it in there, but I'll put a link to the docs for reference in the future.

severn-everett · 2024-05-23T15:19:04Z

Btw if you've got any idea about how to investigate why the kotlin-stdlib-js:1.9.23 library is cached in Gradle plugin repository and not the kotlin-stdlib-js:2.0.0 library, I'd appreciate the guidance, because requiring the Maven repository declaration to come first seems fragile as a solution.

oshai · 2024-05-23T15:25:08Z

Btw if you've got any idea about how to investigate why the kotlin-stdlib-js:1.9.23 library is cached in Gradle plugin repository and not the kotlin-stdlib-js:2.0.0 library, I'd appreciate the guidance, because requiring the Maven repository declaration to come first seems fragile as a solution.

Maybe open an issue for the kotlin team to investigate with a reproduction?

severn-everett · 2024-05-24T13:51:24Z

Based on my consultation with the Kotlin devs, I suspected that this might have been an issue with IntelliJ, so I re-ran the build after upgrading to IntelliJ 2024.1.2, and it worked.

However, reverting the repository declaration change in the code caused the build to fail in my forked version in a similar manner: https://github.com/severn-everett/kotlin-logging/actions/runs/9224844785

Yet it didn't fail in this project's Github actions: https://github.com/oshai/kotlin-logging/actions/runs/9224845625

Any thoughts?

oshai · 2024-05-25T05:35:09Z

In your fork I saw a different error related to wasm.

severn-everett · 2024-05-27T16:15:28Z

It was the same issue of "Gradle can't find a Kotlin 2 multiplatform dependency in the Gradle Plugins repository", and it's shown up in the Dependabot PR for updating to Kotlin 2 as well. However, I just re-ran the Github actions in my own fork successfully, so either it's a caching issue with Gradle or maybe some race condition. I'll ask the Kotlin devs, but this PR should be good to go now at least.

…tly not required

severn-everett · 2024-05-28T09:49:45Z

According to the Kotlin devs, gradlePluginPortal() isn't required in any case, so I've removed it in my PR. Do we know for sure whether the declaration is necessary all the same?

oshai · 2024-05-29T04:21:24Z

Thanks!
When merging the PR I would like to create a compatibility matrix in the readme as it seems we bumped few Kotlin versions recently.

oshai · 2024-06-04T19:50:26Z

Thanks!

oshai · 2024-06-04T19:56:58Z

My plan is to release this as version 7.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging) | `6.0.9` -> `7.0.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.oshai:kotlin-logging-jvm/7.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.oshai:kotlin-logging-jvm/7.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.oshai:kotlin-logging-jvm/6.0.9/7.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.oshai:kotlin-logging-jvm/6.0.9/7.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oshai/kotlin-logging (io.github.oshai:kotlin-logging-jvm)</summary> ### [`v7.0.0`](https://togithub.com/oshai/kotlin-logging/releases/tag/7.0.0) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.9...7.0.0) #### What's Changed - WASM Anonymous Logging Refinement by [@severn-everett](https://togithub.com/severn-everett) in [https://github.com/oshai/kotlin-logging/pull/424](https://togithub.com/oshai/kotlin-logging/pull/424) - Leverage tail recursion when creating message out of Throwable by [@severn-everett](https://togithub.com/severn-everett) in [https://github.com/oshai/kotlin-logging/pull/423](https://togithub.com/oshai/kotlin-logging/pull/423) - Upgraded Kotlin to 2.0.0 by [@severn-everett](https://togithub.com/severn-everett) in [https://github.com/oshai/kotlin-logging/pull/428](https://togithub.com/oshai/kotlin-logging/pull/428) **Full Changelog**: oshai/kotlin-logging@6.0.9...7.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/StefanLobbenmeier/yt-dlp-compose).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…#761) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging) | `6.0.9` -> `7.0.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.oshai:kotlin-logging-jvm/7.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.oshai:kotlin-logging-jvm/7.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.oshai:kotlin-logging-jvm/6.0.9/7.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.oshai:kotlin-logging-jvm/6.0.9/7.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>oshai/kotlin-logging (io.github.oshai:kotlin-logging-jvm)</summary> ### [`v7.0.0`](https://togithub.com/oshai/kotlin-logging/releases/tag/7.0.0) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/6.0.9...7.0.0) #### What's Changed - WASM Anonymous Logging Refinement by [@severn-everett](https://togithub.com/severn-everett) in [https://github.com/oshai/kotlin-logging/pull/424](https://togithub.com/oshai/kotlin-logging/pull/424) - Leverage tail recursion when creating message out of Throwable by [@severn-everett](https://togithub.com/severn-everett) in [https://github.com/oshai/kotlin-logging/pull/423](https://togithub.com/oshai/kotlin-logging/pull/423) - Upgraded Kotlin to 2.0.0 by [@severn-everett](https://togithub.com/severn-everett) in [https://github.com/oshai/kotlin-logging/pull/428](https://togithub.com/oshai/kotlin-logging/pull/428) **Full Changelog**: oshai/kotlin-logging@6.0.9...7.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/pachli/pachli-android).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

severn-everett added 2 commits May 23, 2024 16:36

Upgraded Kotlin to 2.0.0

5a943c3

Using JVM target for all "compile Kotlin" tasks

5ce8fc0

oshai reviewed May 23, 2024

View reviewed changes

Added note in build.gradle.kts concerning compiler argument

578b290

severn-everett added 2 commits May 24, 2024 09:20

Added note in build.gradle.kts temporary repository declaration issue

87f4610

Reverted temporary adjustment of repository declaration order

670d41b

Removing Gradle Plugin Portal repository declaration, as it's apparen…

48a255f

…tly not required

oshai merged commit 69c09ac into oshai:master Jun 4, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgraded Kotlin to 2.0.0 #428

Upgraded Kotlin to 2.0.0 #428

severn-everett commented May 23, 2024

oshai May 23, 2024 •

edited

Loading

severn-everett May 23, 2024

severn-everett commented May 23, 2024

oshai commented May 23, 2024

severn-everett commented May 24, 2024

oshai commented May 25, 2024

severn-everett commented May 27, 2024

severn-everett commented May 28, 2024

oshai commented May 29, 2024

oshai commented Jun 4, 2024

oshai commented Jun 4, 2024

Upgraded Kotlin to 2.0.0 #428

Upgraded Kotlin to 2.0.0 #428

Conversation

severn-everett commented May 23, 2024

oshai May 23, 2024 • edited Loading

Choose a reason for hiding this comment

severn-everett May 23, 2024

Choose a reason for hiding this comment

severn-everett commented May 23, 2024

oshai commented May 23, 2024

severn-everett commented May 24, 2024

oshai commented May 25, 2024

severn-everett commented May 27, 2024

severn-everett commented May 28, 2024

oshai commented May 29, 2024

oshai commented Jun 4, 2024

oshai commented Jun 4, 2024

oshai May 23, 2024 •

edited

Loading