fix(config): solve Go compilation issues

oskoperator · Jun 21, 2024 · 31b96e7 · 31b96e7
1 parent e943197
commit 31b96e7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/internal/config/types.go b/internal/config/types.go
@@ -7,6 +7,7 @@ import (
 type Config struct {
 	MimirRuleRequeuePeriod time.Duration
 	AlertingBurnRates      AlertingBurnRates
+	DefaultBaseWindow      time.Duration
 }
 
 type AlertingBurnRates struct {

diff --git a/internal/helpers/prometheus_helper.go b/internal/helpers/prometheus_helper.go
@@ -301,8 +301,8 @@ func (mrs *MonitoringRuleSet) SetupRules() ([]monitoringv1.RuleGroup, error) {
 }
 
 func CreatePrometheusRule(slo *openslov1.SLO, sli *openslov1.SLI) (*monitoringv1.PrometheusRule, error) {
-	cfg := config.NewConfig() // should we initialize the config once somewhere and pass it around? Do we care?
-	baseWindow := config.DefaultBaseWindow
+	cfg := config.NewConfig()
+	baseWindow := cfg.DefaultBaseWindow.String()
 	if slo.ObjectMeta.Annotations["osko.dev/baseWindow"] != "" {
 		baseWindow = slo.ObjectMeta.Annotations["osko.dev/baseWindow"]
 	}