Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slo): sli inline support and type fixes #18

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

Hy3n4
Copy link
Contributor

@Hy3n4 Hy3n4 commented Oct 26, 2023

  • add support for inline SLI definition
  • fix SLOSpec.Indicator type
  • add more columns for SLO type

Signed-off-by: Hy3n4 [email protected]

- add suuport for inline SLI definition
- fixed SLOSpec.Indicator type
Signed-off-by: Hy3n4 <[email protected]>
@Hy3n4 Hy3n4 requested a review from fourstepper October 26, 2023 12:11
Copy link
Contributor

@fourstepper fourstepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

internal/controller/openslo/slo_controller.go Show resolved Hide resolved
@Hy3n4 Hy3n4 merged commit 035efd4 into main Oct 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants