feat(slo): use record rules in PrometheusRules #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basically this adds the functionality to use record rules over the pure metrics - add some more TODOs and fixes from previous merge Signed-off-by: Hy3n4 <[email protected]>
Signed-off-by: Hy3n4 <[email protected]>
Hy3n4
force-pushed
the
prometheus-rule
branch
from
7605f57 to
e8e5b49
Compare
fourstepper
approved these changes
Oct 30, 2023
Now we are able to use labels in the recording rules Signed-off-by: Hy3n4 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically, this adds the functionality to use record rules over the pure metrics
Signed-off-by: Hy3n4 [email protected]