Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: change cli backend to typer #18

Closed
wants to merge 5 commits into from

Conversation

abhijeetSaroha
Copy link
Contributor

Change CLI backend to typer.

Solves #12

@abhijeetSaroha
Copy link
Contributor Author

I have tries the file paths with Path but in backend, in some functions, it uses endswith method of str which is not compatible with Path type so, I don't change the type of file paths.

@abhijeetSaroha
Copy link
Contributor Author

All commands works fine except text_to_speech, it gives error related to path. Most probably, error comes from backend.

But with all other commands, they work seamlessly.
image

@xmnlab
Copy link
Member

xmnlab commented Jan 19, 2024

thanks for working on that @abhijeetSaroha !

in general looks good. some initial comments:

feel free to ping me if you have any questions! thanks

@abhijeetSaroha
Copy link
Contributor Author

abhijeetSaroha commented Jan 19, 2024

There are some uncommited changes like in dev.yaml, poetry.lock and pyproject.toml which we done to setup the artbox project in my system. Should I commit or stash those changes before rebase?

@xmnlab
Copy link
Member

xmnlab commented Jan 19, 2024

yep .. just run the rebase and fix that there.
in the rebase, for poetry.lock, you can just remove it manually and run again poetry lock

@abhijeetSaroha
Copy link
Contributor Author

rebase don't run until I commit or stash those changes. So should I stash them ?

@xmnlab
Copy link
Member

xmnlab commented Jan 20, 2024

Hey @abhijeetSaroha,

Not sure if that would fix these conflict issues. But this is how I would do it:

  • squash all your commits. You have 5 commits, so you should run the following command:

git rebase -i HEAD~6

Note: as we need to squash your 5 commits we need to rebase it on top of the 6th.

It should open an editor with all your 5 commits.

The first commit should be a pick (default), the all the other ones should be a flush.

Change each line with your 4 ladt commits.

Save and exit. If everything worked ot will squash all your commits in your first commit.

If that worked, rebase your branch on top of the upstream/main:

git rebase -i upstream/main, you don't need to change anything, just save it an exit.

It will fail for that 2 files. It is Ok:

rm poetry.lock and poetry lock

For the change log, run checkout upstream/main -- docs/changelog.md

It will get the changelog.md from the upstream main.

Add your changes git add -u and continue with the rebase git rebase --continue

Hope this will fix your issue there

@abhijeetSaroha
Copy link
Contributor Author

Let me open an another pull request from scratch.

@abhijeetSaroha abhijeetSaroha deleted the cli-typer branch January 21, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants