-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: change cli backend to typer #18
Conversation
I have tries the file paths with |
thanks for working on that @abhijeetSaroha ! in general looks good. some initial comments:
feel free to ping me if you have any questions! thanks |
There are some uncommited changes like in |
yep .. just run the rebase and fix that there. |
rebase don't run until I commit or stash those changes. So should I stash them ? |
Hey @abhijeetSaroha, Not sure if that would fix these conflict issues. But this is how I would do it:
Note: as we need to squash your 5 commits we need to rebase it on top of the 6th. It should open an editor with all your 5 commits. The first commit should be a pick (default), the all the other ones should be a flush. Change each line with your 4 ladt commits. Save and exit. If everything worked ot will squash all your commits in your first commit. If that worked, rebase your branch on top of the upstream/main:
It will fail for that 2 files. It is Ok:
For the change log, run It will get the changelog.md from the upstream main. Add your changes Hope this will fix your issue there |
Let me open an another pull request from scratch. |
Change CLI backend to
typer
.Solves #12