Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.gitignore): update based on github proposed template #218

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

Naman-Priyadarshi
Copy link
Contributor

@Naman-Priyadarshi Naman-Priyadarshi commented Feb 20, 2024

Pull Request description

Updated .gitignore for template as per github proposed template

Fixes #212

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naman-Priyadarshi please follow the PR title format explained here.

@Naman-Priyadarshi Naman-Priyadarshi changed the title fix(.gitignore): Update based on GitHub proposed template chore(.gitignore): update based on github proposed template Feb 21, 2024
@Naman-Priyadarshi
Copy link
Contributor Author

@Saransh-cpp done!

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Naman-Priyadarshi! A comment below -

src/scicookie/{{cookiecutter.project_slug}}/.gitignore Outdated Show resolved Hide resolved
@Naman-Priyadarshi Naman-Priyadarshi force-pushed the git-ignore-update branch 2 times, most recently from 27018af to 12c4fe6 Compare March 1, 2024 20:18
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saransh-cpp
Copy link
Member

Could you also update the repo's .gitignore - https://github.com/osl-incubator/scicookie/blob/main/.gitignore?

@Naman-Priyadarshi
Copy link
Contributor Author

Done!

@Saransh-cpp Saransh-cpp merged commit 8afa5ef into osl-incubator:main Mar 11, 2024
11 checks passed
@Naman-Priyadarshi Naman-Priyadarshi deleted the git-ignore-update branch March 12, 2024 09:34
Copy link

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

YurelyCamacho pushed a commit to YurelyCamacho/cookiecutter-python that referenced this pull request Dec 27, 2024
…bator#218)

* fix(.gitignore): Update based on GitHub proposed template

* make .gitignore dynamic based on selected backend

* comment out files

* update-repo-gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

template: Update .gitignore
3 participants