Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post offices #1035

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Conversation

wmisener
Copy link
Collaborator

@wmisener wmisener commented Feb 19, 2024

Makes progress on #435 and #692. Renders post offices (amenity=post_office, aka in OMT class=post + subclass=post_office) with an envelope icon. This is quite similar to the Carto and Maki approaches.
Screen Shot 2024-02-18 at 6 07 04 PM

I've sometimes seen American maps render an envelope with the bottom folds as well, making more of an 'x' shape. See e.g. the NPS or the MUTCD. I'm open to this style of envelope, but in the end I didn't think that the extra visual clutter made it that much more identifiable.

The icon comes in at z15, the same as other 'community anchor' POIs. I went with blue color, since I see post offices as more of a community service provider than a consumer destination.
Screen Shot 2024-02-18 at 9 13 48 AM

Unfortunately, in my opinion, there is no information in the tiles we can reliably use to distinguish public post offices (like the USPS) from private ones (UPS Stores, etc), as mentioned in #435 (comment). So this PR renders them both identically, although I see distinguishing them in the future as desirable. This would be a good use case for using operator:type or operator:wikidata were those tags to be exposed in OMT, similar to what's been discussed more broadly for supporting brand logos (#809).
Screen Shot 2024-02-18 at 9 14 19 AM

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Sorry for the delay in reviewing.

@ZeLonewolf ZeLonewolf merged commit 44b252e into osm-americana:main Mar 16, 2024
6 checks passed
This was referenced Jul 19, 2024
@wmisener wmisener deleted the wmisener/post_office branch November 24, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants