Add Halifax bridge shields #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claysmalley
added
enhancement
|
https://www.openstreetmap.org/relation/17510849 is now propagated to the tiles but the shield still isn't showing up. Not sure why. https://preview.ourmap.us/pr/1049/#map=15.76/44.677366/-63.611834
|
|
|
|
This is now ready for review. 
|
claysmalley
approved these changes
May 1, 2024
Maybe in the future we can achieve this through some sort of composite. Having the icon be separate from the generic white rectangle background. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #912. Halifax has these little signs for its two major bridges that match the design of the scenic route signs of the province.
https://www.openstreetmap.org/relation/9240721
https://www.openstreetmap.org/relation/17510849
(waiting to propagate to tiles)