Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for place=province equivalent to place=state #1174

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

zekefarwell
Copy link
Collaborator

@zekefarwell zekefarwell commented Dec 1, 2024

This adds support for place=province nodes, giving them the same label text treatment as already supported place=state nodes. The status quo for Canadian provinces is that their place nodes have been tagged place=state but should they be changed to place=province we'd still want labels on the map. It looks like place=province is currently used in a few other countries including Turkey, Thailand, and Japan. We should make sure these are direct country subdivisions before merging this.

@ZeLonewolf
Copy link
Member

Confirmed that this works on the current planet (before restoration of place=state nodes).

I think this can be done a bit more compactly with a single "in" expression, something like:

filter: ["in", ["get", "class"], "state", "province"]

src/layer/place.js Outdated Show resolved Hide resolved
@zekefarwell zekefarwell requested a review from 1ec5 December 2, 2024 00:32
@zekefarwell
Copy link
Collaborator Author

Here's a overpass query showing all place=province nodes worldwide: https://overpass-turbo.eu/s/1V25

It looks to me like the place=province nodes are used consistently across Turkey, Thailand, South Korea, and Japan to represent direct national subdivisions. Beyond that, the tag is used sporadically in Italy, Saudi Arabia, Burundi, and Peru. These uses are less clear to me but there are only a few of them. place=province is clearly documented as being for "a subdivision of a country similar to a state". So I'm fairly confident this is a good change and if any current uses are for lower level divisions they should be changed anyway.

@zekefarwell zekefarwell merged commit 629ca66 into main Dec 2, 2024
6 checks passed
@zekefarwell zekefarwell deleted the zeke-place-province branch December 2, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants