PRC and Hong Kong shields #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
ZeLonewolf
reviewed
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added route shields for the PRC and Hong Kong.
The last two digits of the auxiliary national expressway shield should be smaller than the first two digits, but that would require custom drawing code, so for now all the digits are the same size.
China’s portion of the Asian Highway network is not yet supported because there’s currently no tagging distinction between the Chinese AH shields and the ones used in other countries: #122.
To generate the previews below, I had to comment out this style’s spritesheet. Otherwise, #191 prevented me from seeing anything in China.
Beijing
Chongqing
Hong Kong, Macau, and Shenzhen