Trans-Canada Highway shield #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Nice handling of the TCH shield, I've been thinking about this route for a while but never sat down and created any shield artwork. This was essentially the approach that I had been leaning toward though, so 👍 from me! |
ZeLonewolf
approved these changes
Mar 15, 2022
|
That's also what I was looking to post here as well. |
Yes, it is expected. The TCH follows Autoroutes that have the standard red, white, and blue shield. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a route shield for the Trans-Canada Highway based on @TagaSanPedroAko’s recommendation in #218 (comment). The shield background is based very loosely on this public domain image on Wikimedia Commons, with numerous adjustments to make the shape better accommodate an inscribed number.
Ontario inscribes road names on the TCH shield, similar to the Palisades Interstate Parkway shields in New York State. However, this PR keeps the named TCH shields blank because they only supplement the standard provincial route shields. It’s similar to how we’d treat some state scenic route shields like California’s. Unfortunately, OpenMapTiles sorts the TCH shield before the provincial route shields, probably because
CA:transcanada:namedRoutesorts beforeCA:ON:primary.Nova Scotia puts the number on a rectangular plaque beneath the TCH shield, similar to how U.S. Bicycle Routes are signposted. For concision and consistency and expediency, the number has been inscribed onto the shield proper: