Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue hexagon shields for Pakistan National Highways #415

Merged
merged 15 commits into from
Jul 13, 2022

Conversation

bgo-eiu
Copy link
Contributor

@bgo-eiu bgo-eiu commented Jun 13, 2022

As this shape is already included in the repository for Japanese prefectural shields, this PR changes the name of the SVG file for the blue hexagonal shield shape from a country specific description to hexagon_blue. The shield_defs.js file has then been updated to reflect these changes for Japanese prefectural shields, and to include the Pakistan National Highway shields described in #396 using the same parameters.

@bgo-eiu
Copy link
Contributor Author

bgo-eiu commented Jun 13, 2022

Example, N-5 at Torkham
image

@claysmalley claysmalley linked an issue Jun 13, 2022 that may be closed by this pull request
Copy link
Member

@claysmalley claysmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a better naming scheme to distinguish horizontally-oriented and vertically-oriented hexagon shields. I would recommend adding horizontal to the blue hexagon shield's filename. I gave the following shield the name shield40_hexagon_wide_green.svg, but wide should probably be changed to vertical:

Text inside this shield is very small when it has 4 or more characters. The photos in #396 indicate that the hexagon can be horizontally expanded to accommodate longer text, so let's make a variant of this SVG with a width somewhere between 25 and 30 pixels, whatever looks right:

Screenshot from 2022-06-13 08-54-00

@ZeLonewolf
Copy link
Member

Horizontal means the pointy ends east and west, right?

@claysmalley
Copy link
Member

That's what I'm thinking. Two of the six sides of the hexagon run horizontally.

@michaelblyons
Copy link
Contributor

michaelblyons commented Jun 13, 2022

Horizontal means the pointy ends east and west, right?

That makes sense to me. For a pentagon or other odd-sided figure, I'd name its orientation by the cardinal side with a vertex (i.e. the ones like this pentagon are "up").

See also: Graphviz shapes, particularly triangle/invtriangle.

@claysmalley
Copy link
Member

Here's a wider hexagon I think matches the real-life signs a little better:

shield40_hexagon_horizontal_blue_3

Don't worry about renaming the files; I'll refactor it all eventually.

@bgo-eiu
Copy link
Contributor Author

bgo-eiu commented Jun 18, 2022

Oh thank you! I've been waiting to have time to make a green semi circle SVG for the motorways and one for Lahore Ring Road. I heard back from the active Pakistani route mapper and they said the tags I suggested for those are fine so long as I don't change any of the tags that relate to them being controlled access highways.

@ZeLonewolf ZeLonewolf marked this pull request as draft June 19, 2022 00:48
@ZeLonewolf
Copy link
Member

Setting to draft pending shield update

@claysmalley
Copy link
Member

Here's a motorway shield:

shield40_pk_motorway

I played around with the Lahore Ring Road shield and I couldn't manage to make the text big enough to be legible. This route may need an ovalShield or pillShield treatment.

@claysmalley
Copy link
Member

Shields are up and running:

Screenshot from 2022-07-13 18-07-34

@claysmalley claysmalley marked this pull request as ready for review July 13, 2022 22:09
Copy link
Member

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go. We can continue to track provincial and district roads in #396.

@claysmalley claysmalley removed a link to an issue Jul 13, 2022
@claysmalley claysmalley merged commit abbcaef into osm-americana:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants