-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blue hexagon shields for Pakistan National Highways #415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need a better naming scheme to distinguish horizontally-oriented and vertically-oriented hexagon shields. I would recommend adding horizontal
to the blue hexagon shield's filename. I gave the following shield the name shield40_hexagon_wide_green.svg
, but wide
should probably be changed to vertical
:
Text inside this shield is very small when it has 4 or more characters. The photos in #396 indicate that the hexagon can be horizontally expanded to accommodate longer text, so let's make a variant of this SVG with a width somewhere between 25 and 30 pixels, whatever looks right:
Horizontal means the pointy ends east and west, right? |
That's what I'm thinking. Two of the six sides of the hexagon run horizontally. |
That makes sense to me. For a pentagon or other odd-sided figure, I'd name its orientation by the cardinal side with a vertex (i.e. the ones like this are "up"). See also: Graphviz shapes, particularly |
Oh thank you! I've been waiting to have time to make a green semi circle SVG for the motorways and one for Lahore Ring Road. I heard back from the active Pakistani route mapper and they said the tags I suggested for those are fine so long as I don't change any of the tags that relate to them being controlled access highways. |
Setting to draft pending shield update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to go. We can continue to track provincial and district roads in #396.
As this shape is already included in the repository for Japanese prefectural shields, this PR changes the name of the SVG file for the blue hexagonal shield shape from a country specific description to
hexagon_blue
. Theshield_defs.js
file has then been updated to reflect these changes for Japanese prefectural shields, and to include the Pakistan National Highway shields described in #396 using the same parameters.