Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Attempt to) stop jumping markers for duplicate wiki pages #1958

Merged
merged 3 commits into from
Jul 16, 2023

Conversation

frodrigo
Copy link
Member

Complementary to #1922

Famlam and others added 2 commits July 14, 2023 10:17
@frodrigo frodrigo requested a review from Famlam July 14, 2023 10:19
@Famlam

This comment was marked as outdated.

@Famlam
Copy link
Collaborator

Famlam commented Jul 15, 2023

I had to confirm this for myself with a real run on an extract (results below), but by setting the first value already in tid in b, the (array_agg(tid))[1:10] will just grab the first element 10 times, instead of grabbing the first 10 elements (of the 19 in total for this case).

E.g., the following result (part of the results from Gelderland) just refers to node 10285752983 ten times.

<error class="1">
<node id="10285752983" lat="51.8119529" lon="5.2496313" version="1" user="FrankOverman">
<tag k="url" v="https://map.stolpersteine.app/nl/zaltbommel/locaties/boschstraat-65" />
<tag k="historic" v="memorial" />
<tag k="memorial" v="stolperstein" />
<tag k="wikipedia" v="nl:Lijst van Stolpersteine in Zaltbommel" />
</node>
<node id="10285752983" lat="51.8119529" lon="5.2496313" version="1" user="FrankOverman">
<tag k="url" v="https://map.stolpersteine.app/nl/zaltbommel/locaties/boschstraat-65" />
<tag k="historic" v="memorial" />
<tag k="memorial" v="stolperstein" />
<tag k="wikipedia" v="nl:Lijst van Stolpersteine in Zaltbommel" />
</node>
<node id="10285752983" lat="51.8119529" lon="5.2496313" version="1" user="FrankOverman">
<tag k="url" v="https://map.stolpersteine.app/nl/zaltbommel/locaties/boschstraat-65" />
<tag k="historic" v="memorial" />
<tag k="memorial" v="stolperstein" />
<tag k="wikipedia" v="nl:Lijst van Stolpersteine in Zaltbommel" />
</node>
<node id="10285752983" lat="51.8119529" lon="5.2496313" version="1" user="FrankOverman">
<tag k="url" v="https://map.stolpersteine.app/nl/zaltbommel/locaties/boschstraat-65" />
<tag k="historic" v="memorial" />
<tag k="memorial" v="stolperstein" />
<tag k="wikipedia" v="nl:Lijst van Stolpersteine in Zaltbommel" />
</node>
<node id="10285752983" lat="51.8119529" lon="5.2496313" version="1" user="FrankOverman">
<tag k="url" v="https://map.stolpersteine.app/nl/zaltbommel/locaties/boschstraat-65" />
<tag k="historic" v="memorial" />
<tag k="memorial" v="stolperstein" />
<tag k="wikipedia" v="nl:Lijst van Stolpersteine in Zaltbommel" />
</node>
<node id="10285752983" lat="51.8119529" lon="5.2496313" version="1" user="FrankOverman">
<tag k="url" v="https://map.stolpersteine.app/nl/zaltbommel/locaties/boschstraat-65" />
<tag k="historic" v="memorial" />
<tag k="memorial" v="stolperstein" />
<tag k="wikipedia" v="nl:Lijst van Stolpersteine in Zaltbommel" />
</node>
<node id="10285752983" lat="51.8119529" lon="5.2496313" version="1" user="FrankOverman">
<tag k="url" v="https://map.stolpersteine.app/nl/zaltbommel/locaties/boschstraat-65" />
<tag k="historic" v="memorial" />
<tag k="memorial" v="stolperstein" />
<tag k="wikipedia" v="nl:Lijst van Stolpersteine in Zaltbommel" />
</node>
<node id="10285752983" lat="51.8119529" lon="5.2496313" version="1" user="FrankOverman">
<tag k="url" v="https://map.stolpersteine.app/nl/zaltbommel/locaties/boschstraat-65" />
<tag k="historic" v="memorial" />
<tag k="memorial" v="stolperstein" />
<tag k="wikipedia" v="nl:Lijst van Stolpersteine in Zaltbommel" />
</node>
<node id="10285752983" lat="51.8119529" lon="5.2496313" version="1" user="FrankOverman">
<tag k="url" v="https://map.stolpersteine.app/nl/zaltbommel/locaties/boschstraat-65" />
<tag k="historic" v="memorial" />
<tag k="memorial" v="stolperstein" />
<tag k="wikipedia" v="nl:Lijst van Stolpersteine in Zaltbommel" />
</node>
<node id="10285752983" lat="51.8119529" lon="5.2496313" version="1" user="FrankOverman">
<tag k="url" v="https://map.stolpersteine.app/nl/zaltbommel/locaties/boschstraat-65" />
<tag k="historic" v="memorial" />
<tag k="memorial" v="stolperstein" />
<tag k="wikipedia" v="nl:Lijst van Stolpersteine in Zaltbommel" />
</node>
<location lat="51.8119529" lon="5.2496313" />
<text lang="en" value="nl:Lijst van Stolpersteine in Zaltbommel" />
</error>

@frodrigo
Copy link
Member Author

You are right, fixed.

@Famlam

This comment was marked as outdated.

@Famlam
Copy link
Collaborator

Famlam commented Jul 15, 2023

It seems to work ok now 👍

@frodrigo frodrigo merged commit da081ac into osm-fr:dev Jul 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants