Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove false positives for incorrect tag check #1974

Merged

Conversation

pixunil
Copy link
Contributor

@pixunil pixunil commented Jul 29, 2023

I found three documented tags that I believe are false positives as they are documented in the wiki. Especially bicycle=optional_sidepath and crossing=informal have a rather large occurrence.

@Famlam
Copy link
Collaborator

Famlam commented Jul 29, 2023

bicycle=optional_sidepath is controversial according to the wiki of key:bicycle. Not sure what it tries to imply either, if you're allowed to be there with equal priority as on the optional cycleway, it's simply a duplicate of "bicycle=yes".

crossing=informal is another Streetcomplete tag that causes a lot of bad tagging in my area since some streetcomplete users don't understand the difference between a purpose crossing and an informal one because their quest seems to imply that any crossing without a lowered curb or lines or so is an informal one :/. I usually have to revert them. So personally I like keeping the warning, makes it easy to spot the bad tagging :). (Out of the scope of this PR, but maybe another analyser should first check whether the way is informal before a crossing can be informal to catch such cases?)

dog=outside seems to be used only 98 times worldwide, but makes sense to me.

Just my opinion about the tags. I'll leave it to others to decide on the PR :)

@pixunil
Copy link
Contributor Author

pixunil commented Jul 30, 2023

Thanks for your feedback!
Regarding bicycle=optional_sidepath, I only found on bicycle this sentence:

note that standard tagging for that info is cycleway=separate and cycleway:left=separate / cycleway:right=separate / cycleway:both=separate variants

Is this the controversion you are referring to? I would argue that optional_sidepath matches use_sidepath to refer to the sidepath while keeping the access to yes. However, it might be not applicable to all countries.

Regarding crossing=informal, I share your criticism of the wording in the quest. If in the current situation it is better for Osm QA to manually resolve real informal crossings as the tagging is so error-prone, it would be fine to me to keep them flagged.

@Famlam
Copy link
Collaborator

Famlam commented Jul 30, 2023

Yes, that's what I'm referring to.
All other bicycle values give access values (use_sidepath for instance in NL means "not allowed, except when you're too wide", no means no, designated means it's specially for you, etc).
This one just says "yes, with another possibility nearby". Which is just "yes", because the optional cycleway doesn't affect the access of the nearby way.

For crossing=informal I guess I (or you?) will have to write a separate SQL query to catch the many rotten apples. But I guess that doesn't have to stop this PR until then.. Just not so happy to lose my "how to find them" method I guess 😅

@Famlam
Copy link
Collaborator

Famlam commented Jul 30, 2023

Filed an issue to add an analyzer for bad informal crossings later on :)

@frodrigo
Copy link
Member

frodrigo commented Aug 2, 2023

So, @Famlam your are in favour of only keep dog=outside ?

@Famlam
Copy link
Collaborator

Famlam commented Aug 2, 2023

I think it can be merged as it is, or without optional_sidepath.

I don't like the tag crossing=informal due to its common misuse, but the tag itself is valid, so we need to get a more appropriate check to find the bad ones (for which I filed a corresponding issue), but that's unrelated to the tag itself being valid. So this can be merged.

Optional_sidepath so far mostly seems to be a German tag, and with the necessary controversy on the wiki. So I personally would prefer to keep it out until resolved, but on the other hand, no hard feelings if we stop warning about it. (I'll bring it up in the Dutch community when my schedule allows)

Up to you :)

@frodrigo frodrigo merged commit a618d00 into osm-fr:dev Aug 2, 2023
2 of 3 checks passed
@frodrigo
Copy link
Member

frodrigo commented Aug 2, 2023

Thank you. Merged. Deploy in progress.

@pixunil pixunil deleted the remove-false-positives-for-incorrect-tag branch August 3, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants