-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove false positives for incorrect tag check #1974
Remove false positives for incorrect tag check #1974
Conversation
Both tags are documented in the wiki and in use: https://wiki.openstreetmap.org/wiki/Tag:bicycle%3Doptional_sidepath https://wiki.openstreetmap.org/wiki/Tag%3Adog%3Doutside
Closes osm-fr/osmose-frontend#473 This tag is mentioned in the wiki and is used by StreetComplete https://wiki.openstreetmap.org/wiki/Tag:crossing=informal
Just my opinion about the tags. I'll leave it to others to decide on the PR :) |
Thanks for your feedback!
Is this the controversion you are referring to? I would argue that Regarding |
Yes, that's what I'm referring to. For |
Filed an issue to add an analyzer for bad informal crossings later on :) |
So, @Famlam your are in favour of only keep |
I think it can be merged as it is, or without optional_sidepath. I don't like the tag crossing=informal due to its common misuse, but the tag itself is valid, so we need to get a more appropriate check to find the bad ones (for which I filed a corresponding issue), but that's unrelated to the tag itself being valid. So this can be merged. Optional_sidepath so far mostly seems to be a German tag, and with the necessary controversy on the wiki. So I personally would prefer to keep it out until resolved, but on the other hand, no hard feelings if we stop warning about it. (I'll bring it up in the Dutch community when my schedule allows) Up to you :) |
Thank you. Merged. Deploy in progress. |
I found three documented tags that I believe are false positives as they are documented in the wiki. Especially
bicycle=optional_sidepath
andcrossing=informal
have a rather large occurrence.