Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date format in analyser_merge_power_plant_FR #1844 #1980

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Fix date format in analyser_merge_power_plant_FR #1844 #1980

merged 2 commits into from
Aug 7, 2023

Conversation

frodrigo
Copy link
Member

@frodrigo frodrigo commented Aug 6, 2023

No description provided.

@Famlam
Copy link
Collaborator

Famlam commented Aug 7, 2023

If the dates in the source are now in /-separated format, are the "-01-01" and "-12-31" checks still needed then?

@frodrigo
Copy link
Member Author

frodrigo commented Aug 7, 2023

If the dates in the source are now in /-separated format, are the "-01-01" and "-12-31" checks still needed then?

Right. Need also format update. Thank you.

@Famlam
Copy link
Collaborator

Famlam commented Aug 7, 2023

Not startswith and the other way around? Since the format needs to be inverted after the split?
(If these data entries still exist)

@frodrigo
Copy link
Member Author

frodrigo commented Aug 7, 2023

Not startswith and the other way around? Since the format needs to be inverted after the split? (If these data entries still exist)

Still right ! Sorry for too quick fixing.

@frodrigo frodrigo merged commit d410b66 into osm-fr:dev Aug 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frodrigo @Famlam