Don't warn about polygons for (self-intersecting) ways that are no polygons #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1935 and the second part of #1995
For
attraction=roller_coaster(area surrounding the rollercoaster) vsroller_coaster=track(the track itself), see #1960Note: personally I think that self-intersecting ways can better be split in fragments that do not overlap, especially for rollercoasters where they cross at different heights (and should thus have
layertags). This PR is mostly based upon #1935 (comment) : it's not a polygon, so the warning doesn't make sense.