Fix 1831 - bicycle lane can be a regular lane #2002
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although common, bicycle:lanes=designated does not necessarily mean a cycleway=lane (/half-width lane). Hence, rather than forcing an exact match, allow the bicycle:lanes to count or not to count. Most countries seem to be unaffected.
I purposefully didn't add a
cycleway=*
check but went for this more generic approach, because thecycleway=*share*
approach would be very problematic:cycleway=share*
on a oneway withoneway:bicycle=no
is somewhat ambiguous,cycleway:left=opposite_share*
is very ambiguouscycleway=lane
and a designated shared regular lane at the same time (e.g. at a turn)cycleway=share* / cycleway:both / cycleway:left / cycleway_right
conversions (+oneway
andoneway:bicycle
cases)cycleway=shared_lane
refers to a half-width lane, in others to a full width lane, so we need this code anywayDeals with #1831
As the majority of the cases the text about half/full width cases is correct, I did not modify the text message.