Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1831 - bicycle lane can be a regular lane #2002

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

Famlam
Copy link
Collaborator

@Famlam Famlam commented Aug 26, 2023

Although common, bicycle:lanes=designated does not necessarily mean a cycleway=lane (/half-width lane). Hence, rather than forcing an exact match, allow the bicycle:lanes to count or not to count. Most countries seem to be unaffected.

I purposefully didn't add a cycleway=* check but went for this more generic approach, because the cycleway=*share* approach would be very problematic:

  1. cycleway=share* on a oneway with oneway:bicycle=no is somewhat ambiguous, cycleway:left=opposite_share* is very ambiguous
  2. It'll fail in case there's a cycleway=lane and a designated shared regular lane at the same time (e.g. at a turn)
  3. It's 100% limited to bicycles, can't be expanded like the remainder of the half-width lane code to other narrow vehicles if desired in the future
  4. It'd require a lot more code to deal with cycleway=share* / cycleway:both / cycleway:left / cycleway_right conversions (+ oneway and oneway:bicycle cases)
  5. In some countries, cycleway=shared_lane refers to a half-width lane, in others to a full width lane, so we need this code anyway

Deals with #1831

As the majority of the cases the text about half/full width cases is correct, I did not modify the text message.

Although common, bicycle:lanes=designated does not necessarily mean a cycleway=lane.
This approach also works if cycleway(:*)=*share* is not tagged (for example because it differs per shared lane) and avoids the opposite_* and similar interpretation debate of the cycleway tag
@frodrigo frodrigo merged commit ec95a44 into osm-fr:dev Aug 27, 2023
3 checks passed
@Famlam Famlam deleted the cycleway-designated-on-regular-lane branch August 27, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants