Improve class 31608 description #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure the full tag is stored in `stars` so that the tag is available for the message. - A nice side effect is that both class 31608 and 31603 now also detect conflicts between for example (31603: `destination:ref:lanes` and `destination:ref:lanes:forward`) or (31608: `lanes(destination:ref:lanes:backward)=2` + `lanes(destination:lanes:backward)=1)`. Previously those were undetected - Avoid outputting confusing messages like `lanes(lanes:lanes)=1` when there is no tag `lanes:lanes`, or `lanes(lanes:*:backward)=2` when the tag is actually `lanes:backward`. - Add some comments to the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stars, rather than only the fragment before the first:, so that the tag is available for the message.destination:ref:lanesanddestination:ref:lanes:forwardlanes(destination:ref:lanes:backward)=2+lanes(destination:lanes:backward)=1)lanes(lanes:lanes)=1when there is no taglanes:lanes, orlanes(lanes:*:backward)=2when the tag is actuallylanes:backward.Examples of changed output:
(lanes(turn:*:backward)=2) - (non fullwidth=0) != (lanes(lanes:lanes:backward)=1) - (non fullwidth=0)(lanes(turn:lanes:backward)=2) - (non fullwidth=0) != (lanes(lanes:backward)=1) - (non fullwidth=0)(lanes(lanes:*:forward)=3) - (non fullwidth=0) != (lanes(change:lanes:forward)=1) - (non fullwidth=0)(lanes(lanes:forward)=3) - (non fullwidth=0) != (lanes(change:lanes:forward)=1) - (non fullwidth=0)