Extend invalid access value check to *:lanes
#2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the "invalid access value"-check to
*:lanes.For
:lanes:conditionalthings can get quite complicated (without embedding the conditional value parser), so it only checks the first value. Maybe I'll incorporate it in the future.Examples:
bus:lanes=yes|yes|designed(class 30404)Unknown access value "designed" for key "bus:lanes"
(Should be
designated)access:lanes=yes|yes|yes|bus(class 30405)Access value "bus" for key "access:lanes" is a transport mode. Consider using "access:lanes = ... + bus:lanes = ..." instead
(In this case access:lanes should be deleted altogether, but that's up to the user as there's too many exceptions possible, depending on e.g. other access tags, highway defaults, ...)