Test if plugin errors from tests are unique #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the
check_errfunction of the plugin tests to also verify that an error is unique. Since plugin-errors are by definition on a per-OSM-object basis, it only needs to ensure there's a unique combination of class+subclass.It would of course only catch situations that are actually checked with check_err, but every bit of safety is better than a frontend crash due to a duplicate entry :). For regular (Osmosis) analysers with test cases, such a test already exists.
An example case would for instance be if someone would replace the
set(...)of TagFix_Access bylist(...), after which this test line would throw two equal errors for bad valuenope. Obviously that's just a hypothetical case :)