Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed name tag for IGA (Australia) #7578

Merged
merged 2 commits into from
Dec 26, 2022
Merged

Removed name tag for IGA (Australia) #7578

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dcc09b
Removed name tag for IGA (Australia)
Scottie0001 Dec 25, 2022
eb9151d
Added "preserveTags" line
Scottie0001 Dec 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion data/brands/shop/supermarket.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3175,7 +3175,6 @@
"tags": {
"brand": "IGA",
"brand:wikidata": "Q5970945",
"name": "IGA",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in new POIs with this brand having no name by default. Is it incorrect or only suboptimal to tag it with a name of “IGA”?

To keep “IGA” as the default name but allow the user to easily modify an individual location’s name, keep the name but add a preserveTags to the entry instead:

name-suggestion-index/data/brands/shop/supermarket.json

Line 850 in 8dcc09b

"preserveTags": ["^name"],

This will keep the Name field unlocked and suppress the warning that currently occurs when you change the name away from “IGA” to something more specific. This change would be equally applicable to IGA in the United States: #5500 (comment).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the intended result.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would be equally applicable to IGA in the United States: #5500 (comment).

dda2181 applies the same to the IGA entry for North America.

"shop": "supermarket"
}
},
Expand Down