Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route token added #1830

Merged
merged 6 commits into from
Aug 7, 2024
Merged

route token added #1830

merged 6 commits into from
Aug 7, 2024

Conversation

Iamshashvat
Copy link
Contributor

@Iamshashvat Iamshashvat commented Aug 6, 2024

Description

Checklist

Adding Assets

If adding a new asset, please ensure the following:

  • Asset is registered to the Cosmos Chain Registry.
  • Add asset to bottom of zone_assets.json.
    • chain_name and base_denom are provided and use values exactly as defined at the Chain Registry.
    • path is provided, and the IBC channel referenced is registered at the Chain Registry (unless native to Osmosis).
    • osmosis_verified is set to false
    • listing_date_time_utc is specified and accurate
    • Optional: transfer_methods, peg_mechanism, override_properties, canonical, categories, where necessary (see README for details).

Adding Chains

If adding a new chain, please ensure the following:

  • Chain is registered to the Cosmos Chain Registry.
    • Chain's registration must have staking defined, with at least one staking_token denom specified.
    • Chain's registration must have fees defined; at least one fee token has low, average, and high gas prices defined.
  • IBC Connection between chain and Osmosis is registered.
  • Add chain to bottom of zone_chains.json
    • rpc and rest does not have any CORS blocking of the Osmosis domain, and RPC node has have WSS enabled.
    • explorer_tx_url correctly directs to the transaction when the hash is inserted into the URL.

@JeremyParish69
Copy link
Contributor

Thanks for the submission but the chain is still missing. Please add a chain to zone_chains, and include the Adding Chains checklist.

@Iamshashvat
Copy link
Contributor Author

Thanks @JeremyParish69, its updated now!

@JeremyParish69
Copy link
Contributor

Sorry, the check is failing because the IBC connection is not yet registered at the Cosmos Chain Registry: https://github.com/cosmos/chain-registry/tree/master/_IBC

@Iamshashvat
Copy link
Contributor Author

Thanks, for pointing out. cosmos/chain-registry#5128 raised the PR

@JeremyParish69 JeremyParish69 merged commit fc66826 into osmosis-labs:main Aug 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants