Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Andromeda $ANDR #1888

Merged
merged 13 commits into from
Sep 19, 2024
Merged

Conversation

SvansyVonSwansea
Copy link
Contributor

@SvansyVonSwansea SvansyVonSwansea commented Sep 5, 2024

Addition of Andromeda, $ANDR

Description

Checklist

Adding Assets

If adding a new asset, please ensure the following:

  • Asset is registered to the Cosmos Chain Registry.
  • Add asset to bottom of zone_assets.json.
    • chain_name and base_denom are provided and use values exactly as defined at the Chain Registry.
    • path is provided, and the IBC channel referenced is registered at the Chain Registry (unless native to Osmosis).
    • osmosis_verified is set to false
    • listing_date_time_utc is specified and accurate
    • Optional: transfer_methods, peg_mechanism, override_properties, canonical, categories, where necessary (see README for details).

Adding Chains

If adding a new chain, please ensure the following:

  • Chain is registered to the Cosmos Chain Registry.
    • Chain's registration must have staking defined, with at least one staking_token denom specified.
    • Chain's registration must have fees defined; at least one fee token has low, average, and high gas prices defined.
  • IBC Connection between chain and Osmosis is registered.
  • Add chain to bottom of zone_chains.json
    • rpc and rest does not have any CORS blocking of the Osmosis domain, and RPC node has have WSS enabled.
    • explorer_tx_url correctly directs to the transaction when the hash is inserted into the URL.

Addition of Andromeda, $ANDR
Copy link
Contributor Author

@SvansyVonSwansea SvansyVonSwansea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed error

Copy link
Contributor Author

@SvansyVonSwansea SvansyVonSwansea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed error

Copy link
Contributor Author

@SvansyVonSwansea SvansyVonSwansea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format fix 😬

😞 i promise last fix
Copy link
Contributor Author

@SvansyVonSwansea SvansyVonSwansea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

promise last fix 😭

this should work 🤔 💭
Copy link
Contributor Author

@SvansyVonSwansea SvansyVonSwansea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should work 🤔💭

@JeremyParish69
Copy link
Contributor

Please see the checklist. The chain must also be added to zone_chains

@JeremyParish69 JeremyParish69 marked this pull request as draft September 6, 2024 16:46
@SvansyVonSwansea
Copy link
Contributor Author

Please see the checklist. The chain must also be added to zone_chains

thanks. it was added to zone.chains now as well.

adding chain info from zone_chains
Copy link
Contributor Author

@SvansyVonSwansea SvansyVonSwansea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added info from zone_chains

(something went wrong, fix coming)

fixing previous error
@JeremyParish69
Copy link
Contributor

thanks. it was added to zone.chains now as well.

zone_chains still has not been modified in this PR.

@SvansyVonSwansea
Copy link
Contributor Author

thanks. it was added to zone.chains now as well.

zone_chains still has not been modified in this PR.

sorry misread. added now.

@JeremyParish69
Copy link
Contributor

sorry misread. added now.

No you're still not following direction. You keep creating new PRs. It must be added to this PR

@SvansyVonSwansea
Copy link
Contributor Author

sorry misread. added now.

No you're still not following direction. You keep creating new PRs. It must be added to this PR

sorry. i think i did it correctly this time?

@JeremyParish69
Copy link
Contributor

sorry. i think i did it correctly this time?

Yes, it has been added to the zone_chains file now. However the PR still needs a correct title, the asset addition still needs correcting, the conflicts still needs to be resolved, and the checklist needs to be ticked.

@JeremyParish69 JeremyParish69 changed the title Update osmosis.zone_assets.json List Andromeda $ANDR Sep 19, 2024
@JeremyParish69 JeremyParish69 marked this pull request as ready for review September 19, 2024 21:34
@JeremyParish69 JeremyParish69 merged commit a6e0d1c into osmosis-labs:main Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants