-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List Andromeda $ANDR #1888
List Andromeda $ANDR #1888
Conversation
Addition of Andromeda, $ANDR
Addition ANDR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed error
format fix 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format fix 😬
😞 i promise last fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
promise last fix 😭
this should work 🤔 💭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should work 🤔💭
Please see the checklist. The chain must also be added to zone_chains |
thanks. it was added to zone.chains now as well. |
adding chain info from zone_chains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added info from zone_chains
(something went wrong, fix coming)
fixing previous error
zone_chains still has not been modified in this PR. |
sorry misread. added now. |
No you're still not following direction. You keep creating new PRs. It must be added to this PR |
adding andromeda
sorry. i think i did it correctly this time? |
Yes, it has been added to the zone_chains file now. However the PR still needs a correct title, the asset addition still needs correcting, the conflicts still needs to be resolved, and the checklist needs to be ticked. |
Addition of Andromeda, $ANDR
Description
Checklist
Adding Assets
If adding a new asset, please ensure the following:
zone_assets.json
.chain_name
andbase_denom
are provided and use values exactly as defined at the Chain Registry.path
is provided, and the IBC channel referenced is registered at the Chain Registry (unless native to Osmosis).osmosis_verified
is set tofalse
listing_date_time_utc
is specified and accuratetransfer_methods
,peg_mechanism
,override_properties
,canonical
,categories
, where necessary (see README for details).Adding Chains
If adding a new chain, please ensure the following:
staking
defined, with at least onestaking_token
denom specified.fees
defined; at least one fee token has low, average, and high gas prices defined.zone_chains.json
rpc
andrest
does not have any CORS blocking of the Osmosis domain, and RPC node has have WSS enabled.explorer_tx_url
correctly directs to the transaction when the hash is inserted into the URL.