Skip to content

Commit

Permalink
Don't run ValidateBasic on recheck (backport #601) (#602)
Browse files Browse the repository at this point in the history
* Don't run ValidateBasic on recheck (#601)

(cherry picked from commit de3aaa1)

* update changelog

---------

Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
  • Loading branch information
3 people authored Apr 29, 2024
1 parent ca6441c commit d118f79
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 4 deletions.
18 changes: 16 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,22 @@ Ref: https://keepachangelog.com/en/1.0.0/

## [Unreleased]

## [State Compatible]
### [State Breaking]

### [State Compatible]

* (perf) [#601](https://github.com/osmosis-labs/cosmos-sdk/pull/601) Don't run ValidateBasic on recheck

## v24

## [v0.47.5-v24-osmo-5](https://github.com/osmosis-labs/cosmos-sdk/releases/tag/v0.47.5-v24-osmo-5)

* (iavl) [#593](https://github.com/osmosis-labs/cosmos-sdk/pull/593) IAVL async pruning

## [v0.47.5-v24-osmo-4](https://github.com/osmosis-labs/cosmos-sdk/releases/tag/v0.47.5-v24-osmo-4)

* (iavl) [#594](https://github.com/osmosis-labs/cosmos-sdk/pull/594) IAVL bump to fix legacy node key bug

## [v0.47.5-v24-osmo-3](https://github.com/osmosis-labs/cosmos-sdk/releases/tag/v0.47.5-v24-osmo-3)

* (store) [#525](https://github.com/osmosis-labs/cosmos-sdk/pull/525) CacheKV speedups
Expand All @@ -52,7 +64,9 @@ Ref: https://keepachangelog.com/en/1.0.0/

## IAVL v23 v1 Releases

## [Unreleased IAVL v1]
## [v0.47.5-v23-osmo-9-iavl-v1](https://github.com/osmosis-labs/cosmos-sdk/releases/tag/v0.47.5-v23-osmo-9-iavl-v1)

* (iavl) [#593](https://github.com/osmosis-labs/cosmos-sdk/pull/593) IAVL async pruning

## [v0.47.5-v23-osmo-8-iavl-v1](https://github.com/osmosis-labs/cosmos-sdk/releases/tag/v0.47.5-v23-osmo-8-iavl-v1)

Expand Down
6 changes: 4 additions & 2 deletions baseapp/baseapp.go
Original file line number Diff line number Diff line change
Expand Up @@ -675,8 +675,10 @@ func (app *BaseApp) runTx(mode runTxMode, txBytes []byte) (gInfo sdk.GasInfo, re
}

msgs := tx.GetMsgs()
if err := validateBasicTxMsgs(msgs); err != nil {
return sdk.GasInfo{}, nil, nil, 0, err
if mode != runTxModeReCheck {
if err := validateBasicTxMsgs(msgs); err != nil {
return sdk.GasInfo{}, nil, nil, 0, err
}
}

if app.anteHandler != nil {
Expand Down

0 comments on commit d118f79

Please sign in to comment.