chore: v50.x up to date #623
Conversation
…kport cosmos#20266) (cosmos#20269) Co-authored-by: John Letey <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…20261) (cosmos#20327) Co-authored-by: beer-1 <[email protected]>
) (cosmos#20329) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]>
) (cosmos#20366) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…ckport cosmos#20356) (cosmos#20383) Co-authored-by: Shude Li <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…(backport cosmos#20342) (cosmos#20346) Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]>
…smos#20460) Co-authored-by: tianyeyouyou <[email protected]> Co-authored-by: marbar3778 <[email protected]>
…#20459) Co-authored-by: cocoyeal <[email protected]>
Co-authored-by: PolyMa <[email protected]>
Co-authored-by: Sergio Mena <[email protected]> Co-authored-by: sontrinh16 <[email protected]>
Co-authored-by: Marko <[email protected]>
…osmos#20567) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
) (cosmos#20627) Co-authored-by: samricotta <[email protected]> Co-authored-by: marbar3778 <[email protected]>
…) (cosmos#20660) Co-authored-by: Daniel Wedul <[email protected]> Co-authored-by: marbar3778 <[email protected]>
…20690) (cosmos#20712) Co-authored-by: Hieu Vu <[email protected]> Co-authored-by: marbar3778 <[email protected]>
…smos#20692) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Facundo <[email protected]>
…smos#20727) Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
…osmos#20805) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…osmos#20836) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…tGenesis` in simulation test (backport cosmos#18196) (cosmos#20897) Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Julien Robert <[email protected]>
… for simulation test. (backport cosmos#17911) (cosmos#20909) Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Julien Robert <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| WithHeaderHash(req.Hash)) | ||
| } | ||
|
|
||
| if err := app.preBlock(req); err != nil { | ||
| preblockEvents, err := app.preBlock(req) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| events = append(events, preblockEvents...) | ||
|
|
||
| beginBlock, err := app.beginBlock(req) |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).internalFinalizeBlock (baseapp/abci.go:692)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/abci.go:853)
|
Most of the CI jobs fail because we don't have sonarcloud credentials in github. Should I remove them? |
|
Thanks @faddat, the team rn are all testing v26, so this will probs sit here for about a week and a half, I'll come back to it then 🙇 I think I'll see if there's a way to run these with sonarcloud from your branch, if not we may have to cannibalise this PR 😢 |
|
@PaddyMc - I think that some fixes have been ninjaed into the upstream v0.50.x branch, and probably they should get in v26. I'd want them if I were you, anyhow :). I am working with another org right now and we have decided to use this SDK fork -- so if the sonarcloud runs in osmo/v0.50.x but not here, that's totally okay. I will leave the CI config as it currently is in that case, and import from here. That is also the reason for some of the PRs on Since I can push to branches in the Good luck with the release! |
|
Thanks for this PR, but decided to take this on myself so I had a good understanding what is happening 🙇 |
Description
This pull request brings the osmosis cosmos-sdk fork current with changes in the mainline cosmos-sdk.
Since a lot of CI doesn't seem to be working, I've run tests manually, they pass for me :).
I did:
We also got some warnings from the dependency checker and since they looked relatively uncool, I upgraded:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...