Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tests for starship #136

Merged
merged 35 commits into from
Dec 30, 2023
Merged

chore: fix tests for starship #136

merged 35 commits into from
Dec 30, 2023

Conversation

Anmol1696
Copy link
Contributor

@Anmol1696 Anmol1696 commented Dec 12, 2023

Fixing the starship tests.
Bring back starship to life.

Major changes

  • Moved Dockerfile to root dir for context of x/
  • Depricate go to version 1.20
  • Dockerfile changed to use go1.20 and alpine31.7

@pinosu
Copy link
Contributor

pinosu commented Dec 14, 2023

Hey @Anmol1696, fyi wasmd v0.42, v0.43 and v0.44 are retracted, so you should use either v0.41 or v0.45

@@ -72,7 +74,6 @@ jobs:
- name: Publish to GitHub Packages
uses: docker/build-push-action@v4
with:
platforms: linux/amd64,linux/arm64
platforms: linux/amd64 # ,linux/arm64 (removed for debugging)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not forget to unremove as many people use ARM including myself. : )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it so that the chains are mesh-juno-1 and mesh-osmosis-1, complete with the right prefix, denom, etc. (binary can still be meshd). This would make for the best demo, but I had issues when I tried to change these settings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That we have in mesh-security-infra repo. I will make it so that one can deploy that repo locally as well.
Reason to have only meshd here is something that @alpe mentioned about this repo just being the sdk.
The starship tests in this repo can be just around making sure the contracts and everything work with current versions of the sdk and the contracts.

The chain simulation will be part of the other repo

@maurolacy
Copy link
Collaborator

Hey @Anmol1696, fyi wasmd v0.42, v0.43 and v0.44 are retracted, so you should use either v0.41 or v0.45

Shouldn't this information be announced or showcased clearly? By example, in the wasmd releases page?

@pinosu
Copy link
Contributor

pinosu commented Dec 18, 2023

Shouldn't this information be announced or showcased clearly? By example, in the wasmd releases page?

Yes, I will try to document it better. Thank you for the suggestion

@Anmol1696 Anmol1696 changed the title WIP: fix tests for starship chore: fix tests for starship Dec 27, 2023
Copy link

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anmol1696 Anmol1696 merged commit 3cdce6e into main Dec 30, 2023
5 checks passed
@Anmol1696 Anmol1696 mentioned this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants