-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix tests for starship #136
Conversation
79dc1a7
to
1d24ce0
Compare
Hey @Anmol1696, fyi wasmd v0.42, v0.43 and v0.44 are retracted, so you should use either v0.41 or v0.45 |
.github/workflows/docker.yaml
Outdated
@@ -72,7 +74,6 @@ jobs: | |||
- name: Publish to GitHub Packages | |||
uses: docker/build-push-action@v4 | |||
with: | |||
platforms: linux/amd64,linux/arm64 | |||
platforms: linux/amd64 # ,linux/arm64 (removed for debugging) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not forget to unremove as many people use ARM including myself. : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
tests/starship/configs/local.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it so that the chains are mesh-juno-1
and mesh-osmosis-1
, complete with the right prefix, denom, etc. (binary can still be meshd
). This would make for the best demo, but I had issues when I tried to change these settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That we have in mesh-security-infra
repo. I will make it so that one can deploy that repo locally as well.
Reason to have only meshd
here is something that @alpe mentioned about this repo just being the sdk.
The starship tests in this repo can be just around making sure the contracts and everything work with current versions of the sdk and the contracts.
The chain simulation will be part of the other repo
Shouldn't this information be announced or showcased clearly? By example, in the wasmd releases page? |
Yes, I will try to document it better. Thank you for the suggestion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixing the starship tests.
Bring back starship to life.
Major changes
Dockerfile
to root dir for context ofx/
go1.20
andalpine31.7