Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/valset updates #109

Merged
merged 10 commits into from
Aug 28, 2023
Merged

F/valset updates #109

merged 10 commits into from
Aug 28, 2023

Conversation

maurolacy
Copy link
Collaborator

@maurolacy maurolacy commented Aug 22, 2023

Closes #88.

TODO:

  • Unit tests.

@maurolacy maurolacy self-assigned this Aug 22, 2023
@maurolacy maurolacy force-pushed the f/valset-updates branch 2 times, most recently from aa3c7f5 to 28def8c Compare August 23, 2023 10:12
@maurolacy maurolacy marked this pull request as ready for review August 23, 2023 10:19
Copy link
Collaborator

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JakeHartnell JakeHartnell merged commit 5c2ea14 into main Aug 28, 2023
2 checks passed
@JakeHartnell
Copy link
Collaborator

Merging, if you have comments, please submit in the form of PRs. : )

@maurolacy
Copy link
Collaborator Author

maurolacy commented Sep 25, 2023

What is still needed here, and for completeness, would be to add a jails field with a list of validators to be jailed, to the ValsetUpdate message.

Putting this here just for the record. This is irrelevant at this point, but it could be useful / needed if we implement #118. To differentiate between the unbonded state and the (temporarily) jailed state, that is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send validator sync update messages on changing validator set
2 participants