F/slashing #126
F/slashing #126
Conversation
maurolacy
force-pushed
the
f/slashing
branch
3 times, most recently
from
4c1c418
to
8803670
Compare
maurolacy
force-pushed
the
f/slashing
branch
4 times, most recently
from
d4c95f5
to
4a7bffb
Compare
|
OK, that took a while, but I think we now have a correct slashing implementation, at the (vault's) accounting level. Both for slashing and slashing propagation. Just set this as ready for review. Please take a look! #127 is also relevant, for the general overview of the process, and testing scenario definitions. |
maurolacy
force-pushed
the
f/slashing
branch
2 times, most recently
from
5e7e334
to
15ac523
Compare
maurolacy
force-pushed
the
f/slashing
branch
from
05f6eaa
to
15e8f44
Compare
|
k, merging due to popular demand. ;-) I understand this is something that can be used for integration tests, etc. Still, I would very much like a review here, even post-merge. |
| end_time: _end_time, | ||
| } in to_remove | ||
| { | ||
| // Check that the validator is active at height and slash it if that is the case |
There was a problem hiding this comment.
I'm not sure I understand this. It looks like virtual-staking informs external-staking that the validator has been tombstoned, but this triggers a slashing event for users staking on that validator?
There was a problem hiding this comment.
Yes, both tombstoning and jailing always imply slashing.
| /// Slashes a validator. | ||
| /// | ||
| /// In test code, this is called from `test_handle_slashing`. | ||
| /// In non-test code, this is being called from `ibc_packet_receive` (in the `ConsumerPacket::RemoveValidators` |
There was a problem hiding this comment.
I'm probably missing something, but should user slashing not get triggered when a validator itself is slashed?
There was a problem hiding this comment.
There's no specific slashing event. As mentioned, slashing is part of validator tombstone, because of double signing; or of validator jailing, because of being offline.
Closes #11. WIP. Publishing as draft for review / feedback.
TODO:
burn. Likeunstakebut without releasing funds.slash_adjust. For smart contracts accounting, but no blockchain calls (funds already slashed at blockchain level). (wip)